This patch is based on https://reviews.llvm.org/D85897
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/unittests/Tooling/Syntax/TreeTestBase.h | ||
---|---|---|
14 | We can either remove this or #include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/StringRef.h" #include "llvm/Support/Casting.h" #include "llvm/Support/Error.h" I imagine that we'd rather leave the direct includes, in this case should we remove clang/Basic/LLVM.h? |
clang/unittests/Tooling/Syntax/TreeTestBase.h | ||
---|---|---|
14 | clang/Basic/LLVM.h only adds "using" declarations, it does not define the types themselves. So we need to keep both clang/Basic/LLVM.h and ArrayRef.h. |
We can either remove this or
I imagine that we'd rather leave the direct includes, in this case should we remove clang/Basic/LLVM.h?