This is an archive of the discontinued LLVM Phabricator instance.

[SyntaxTree] Clean `#includes` in `TreeTestBase.h`
ClosedPublic

Authored by eduucaldas on Aug 13 2020, 5:35 AM.

Diff Detail

Event Timeline

eduucaldas created this revision.Aug 13 2020, 5:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 5:35 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
eduucaldas requested review of this revision.Aug 13 2020, 5:35 AM
Harbormaster completed remote builds in B68249: Diff 285342.
eduucaldas added inline comments.
clang/unittests/Tooling/Syntax/TreeTestBase.h
14–15

We can either remove this or

#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/Casting.h"
#include "llvm/Support/Error.h"

I imagine that we'd rather leave the direct includes, in this case should we remove clang/Basic/LLVM.h?

eduucaldas edited the summary of this revision. (Show Details)Aug 13 2020, 5:46 AM
eduucaldas marked an inline comment as not done.Aug 13 2020, 5:50 AM
gribozavr2 accepted this revision.Aug 13 2020, 5:51 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/TreeTestBase.h
14–15

clang/Basic/LLVM.h only adds "using" declarations, it does not define the types themselves. So we need to keep both clang/Basic/LLVM.h and ArrayRef.h.

This revision is now accepted and ready to land.Aug 13 2020, 5:51 AM
This revision was landed with ongoing or failed builds.Aug 13 2020, 6:31 AM
This revision was automatically updated to reflect the committed changes.