This is an archive of the discontinued LLVM Phabricator instance.

[SyntaxTree] Split `TreeTest.cpp`
ClosedPublic

Authored by eduucaldas on Aug 13 2020, 5:33 AM.

Details

Reviewers
gribozavr2
Summary

We extract the test infrastructure into TreeTestBase.h and split the
tests into MutationsTest.cpp and BuildTreeTest.cpp

Closed by https://reviews.llvm.org/rGd17437d2bd8e83baee96f2860276d615d216dfbc

Diff Detail

Event Timeline

eduucaldas created this revision.Aug 13 2020, 5:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 5:33 AM
eduucaldas requested review of this revision.Aug 13 2020, 5:33 AM

We can further split BuildTreeTest.cpp for instance in BuildStatementTest.cpp and BuildDeclTest.cpp, I can't see many arguments towards that though.

gribozavr2 accepted this revision.Aug 13 2020, 5:53 AM
gribozavr2 added inline comments.
clang/unittests/Tooling/Syntax/BuildTreeTest.cpp
16

Ditto, please use namespace clang::syntax.

clang/unittests/Tooling/Syntax/TreeTestBase.h
44

Please use the same namespace that the non-test code is using.

This revision is now accepted and ready to land.Aug 13 2020, 5:53 AM
eduucaldas closed this revision.Sep 17 2020, 1:11 AM
eduucaldas edited the summary of this revision. (Show Details)