This is an archive of the discontinued LLVM Phabricator instance.

Differential D85861

[flang] Correct the default value for PAD= to PAD='YES'.
ClosedPublic

Authored by klausler on Aug 12 2020, 4:15 PM.

Details

Reviewers
sscalpone
PeteSteinfeld
jdoerfert
DavidTruby
Summary

It was wrong.

Diff Detail

Event Timeline

klausler created this revision.Aug 12 2020, 4:15 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 12 2020, 4:15 PM
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
klausler requested review of this revision.Aug 12 2020, 4:15 PM
Harbormaster completed remote builds in B68179: Diff 285204.Aug 12 2020, 4:31 PM
PeteSteinfeld accepted this revision.Aug 12 2020, 6:57 PM

Builds, tests, and looks good.

This revision is now accepted and ready to land.Aug 12 2020, 6:57 PM
klausler closed this revision.Aug 13 2020, 10:05 AM

Revision Contents

PathSize
flang/
runtime/
2 lines

Diff 285204

flang/runtime/format.h

Context not available.
enum decimal::FortranRounding round{ enum decimal::FortranRounding round{
executionEnvironment executionEnvironment
.defaultOutputRoundingMode}; // RP/ROUND='PROCESSOR_DEFAULT' .defaultOutputRoundingMode}; // RP/ROUND='PROCESSOR_DEFAULT'
bool pad{false}; // PAD= mode on READ bool pad{true}; // PAD= mode on READ
char delim{'\0'}; // DELIM= char delim{'\0'}; // DELIM=
short scale{0}; // kP short scale{0}; // kP
}; };
Context not available.