Page MenuHomePhabricator

[WebAssembly][AsmParser] Name missing features in error message

Authored by tlively on Aug 11 2020, 4:04 PM.



Rather than just saying that some feature is missing, report the exact
features to make the error message more useful and actionable.

Diff Detail

Event Timeline

tlively created this revision.Aug 11 2020, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2020, 4:04 PM
tlively requested review of this revision.Aug 11 2020, 4:04 PM
dschuff accepted this revision.Aug 11 2020, 4:56 PM
dschuff added inline comments.

might as well add one that requires more than one feature?

This revision is now accepted and ready to land.Aug 11 2020, 4:56 PM
tlively added inline comments.Aug 11 2020, 5:19 PM

I don't think we actually have any such instructions right now. But I'd rather keep the loop to be robust against adding any multi-feature instructions in the future.

dschuff added inline comments.Aug 11 2020, 5:26 PM

hm, guess we missed our opportunity to define atomic SIMD loads :D

This revision was landed with ongoing or failed builds.Aug 11 2020, 5:26 PM
This revision was automatically updated to reflect the committed changes.