This is an archive of the discontinued LLVM Phabricator instance.

[Driver][XRay][test] Update the macOS support check
ClosedPublic

Authored by azharudd on Aug 11 2020, 12:58 PM.

Reviewers

arphaman
dberris

Commits

Summary

For macOS, the code says, the XRay flag is only supported on x86_64.
Updating the test and making that check explicit.

azharudd requested review of this revision.Aug 11 2020, 12:58 PM

LGTM from me if XRay actually does work on non-x86_64 macOS.

This revision is now accepted and ready to land.Aug 11 2020, 5:01 PM

In D85773#2211929, @dberris wrote:

LGTM from me if XRay actually does work on non-x86_64 macOS.

The code says that it is supported only on x86_64 macOS. The way this test is written, it should fail on platforms where it is supported.

(Sorry about the delay here.)

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

test/

Driver/

XRay/

2 lines

	// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s			// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
	// XFAIL: -linux-, -freebsd, -darwin, -macos			// XFAIL: -linux-, -freebsd, x86_64-apple-darwin, x86_64-apple-macos
	// REQUIRES: amd64 \|\| x86_64 \|\| x86_64h \|\| arm \|\| aarch64 \|\| arm64			// REQUIRES: amd64 \|\| x86_64 \|\| x86_64h \|\| arm \|\| aarch64 \|\| arm64
	typedef int a;			typedef int a;