This is an archive of the discontinued LLVM Phabricator instance.

Update AMDGPU testcases after bebe6a6449811e877f7eba3f1798ddd1fa83e440
ClosedPublic

Authored by paquette on Aug 11 2020, 11:01 AM.

Details

Summary

I didn't build AMDGPU locally so I didn't see this.

(logic_op (op x...), (op y...)) -> (op (logic_op x, y))

kicks in here.

Double-checking that this looks good.

Diff Detail

Event Timeline

paquette created this revision.Aug 11 2020, 11:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 11 2020, 11:01 AM
Herald added subscribers: kerbowa, t-tye, tpr and 5 others. · View Herald Transcript
paquette requested review of this revision.Aug 11 2020, 11:01 AM

This immediate diff is better, but I'm not sure what the interaction with D85201 is going to be

I applied D85201 and the tests passed without any conflicts/updates, so it seems fine.

arsenm accepted this revision.Aug 11 2020, 11:27 AM

I applied D85201 and the tests passed without any conflicts/updates, so it seems fine.

Probably also need D85203 and D85202. I guess fix the build for now and I'll have to sort this out when I rebase

This revision is now accepted and ready to land.Aug 11 2020, 11:27 AM