This is an archive of the discontinued LLVM Phabricator instance.

[BasicBlockUtils] Factor MergeBlockIntoPredecessor args into a struct, NFC
AcceptedPublic

Authored by vsk on Aug 7 2020, 2:58 PM.

Details

Reviewers
fhahn
asbirlea
Summary

Factor the arguments to MergeBlockIntoPredecessor into a struct to
make usage of the API more readable.

This is in preparation for a change which adds another knob to
MergeBlockIntoPredecessor.

Diff Detail

Event Timeline

vsk created this revision.Aug 7 2020, 2:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2020, 2:58 PM
vsk requested review of this revision.Aug 7 2020, 2:58 PM
asbirlea accepted this revision.Aug 27 2020, 5:32 PM

lgtm with some nits.

llvm/lib/Transforms/Scalar/GVN.cpp
2230

s/removedBlock/RemovedBlock (see clang-tidy or llvm doc)

2230

Perhaps directly passing: {&DTU, LI, nullptr, MD}?

This revision is now accepted and ready to land.Aug 27 2020, 5:32 PM