This is an archive of the discontinued LLVM Phabricator instance.

Differential D85496

[macho2yaml] Remove unused functions. NFC.
ClosedPublic

Authored by Higuoxing on Aug 6 2020, 8:55 PM.

Details

Reviewers
jhenderson
grimar
MaskRay
Commits
rG100e1f911c0e: [macho2yaml] Remove unused functions. NFC.
Summary

dumpDebugStrings() and dumpDebugAbbrev() are no longer used in
macho2yaml. This patch helps remove them.

Diff Detail

Unit TestsFailed

TimeTest
80 mslinux > Polly.Isl/Ast::alias_checks_with_empty_context.ll

Event Timeline

Higuoxing created this revision.Aug 6 2020, 8:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2020, 8:55 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Higuoxing requested review of this revision.Aug 6 2020, 8:55 PM
Harbormaster completed remote builds in B67411: Diff 283803.Aug 6 2020, 9:06 PM
grimar accepted this revision.Aug 7 2020, 12:51 AM

LGTM

This revision is now accepted and ready to land.Aug 7 2020, 12:51 AM
This revision was landed with ongoing or failed builds.Aug 7 2020, 5:34 AM
Closed by commit rG100e1f911c0e: [macho2yaml] Remove unused functions. NFC. (authored by Higuoxing). · Explain Why
This revision was automatically updated to reflect the committed changes.
Higuoxing added a commit: rG100e1f911c0e: [macho2yaml] Remove unused functions. NFC..

Revision Contents

PathSize
llvm/
tools/
obj2yaml/
4 lines

Diff 283803

llvm/tools/obj2yaml/macho2yaml.cpp

Show All 28 Linesclass MachODumper {
void dumpHeader(std::unique_ptr<MachOYAML::Object> &Y); void dumpHeader(std::unique_ptr<MachOYAML::Object> &Y);
Error dumpLoadCommands(std::unique_ptr<MachOYAML::Object> &Y); Error dumpLoadCommands(std::unique_ptr<MachOYAML::Object> &Y);
void dumpLinkEdit(std::unique_ptr<MachOYAML::Object> &Y); void dumpLinkEdit(std::unique_ptr<MachOYAML::Object> &Y);
void dumpRebaseOpcodes(std::unique_ptr<MachOYAML::Object> &Y); void dumpRebaseOpcodes(std::unique_ptr<MachOYAML::Object> &Y);
void dumpBindOpcodes(std::vector<MachOYAML::BindOpcode> &BindOpcodes, void dumpBindOpcodes(std::vector<MachOYAML::BindOpcode> &BindOpcodes,
ArrayRef<uint8_t> OpcodeBuffer, bool Lazy = false); ArrayRef<uint8_t> OpcodeBuffer, bool Lazy = false);
void dumpExportTrie(std::unique_ptr<MachOYAML::Object> &Y); void dumpExportTrie(std::unique_ptr<MachOYAML::Object> &Y);
void dumpSymbols(std::unique_ptr<MachOYAML::Object> &Y); void dumpSymbols(std::unique_ptr<MachOYAML::Object> &Y);
void dumpDebugAbbrev(DWARFContext &DCtx,
std::unique_ptr<MachOYAML::Object> &Y);
void dumpDebugStrings(DWARFContext &DCtx,
std::unique_ptr<MachOYAML::Object> &Y);
template <typename SectionType> template <typename SectionType>
Expected<MachOYAML::Section> constructSectionCommon(SectionType Sec, Expected<MachOYAML::Section> constructSectionCommon(SectionType Sec,
size_t SecIndex); size_t SecIndex);
template <typename SectionType> template <typename SectionType>
Expected<MachOYAML::Section> constructSection(SectionType Sec, Expected<MachOYAML::Section> constructSection(SectionType Sec,
size_t SecIndex); size_t SecIndex);
template <typename SectionType, typename SegmentType> template <typename SectionType, typename SegmentType>
▲ Show 20 Lines • Show All 560 Lines • Show Last 20 Lines