This is an archive of the discontinued LLVM Phabricator instance.

Differential D85476

[AMDGPU] Correct missing sram-ecc target feature for gfx906
ClosedPublic

Authored by t-tye on Aug 6 2020, 3:06 PM.

Details

Reviewers
kzhuravl
yaxunl
Commits
rGce74e97d9b15: [AMDGPU] Correct missing sram-ecc target feature for gfx906

Diff Detail

Event Timeline

t-tye created this revision.Aug 6 2020, 3:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2020, 3:06 PM
Herald added subscribers: llvm-commits, kerbowa, tpr and 5 others. · View Herald Transcript
t-tye requested review of this revision.Aug 6 2020, 3:06 PM
Herald added a subscriber: wdng. · View Herald TranscriptAug 6 2020, 3:06 PM
t-tye added a reviewer: kzhuravl.Aug 6 2020, 3:07 PM
t-tye added a reviewer: yaxunl.
kzhuravl accepted this revision.Aug 6 2020, 3:11 PM

LGTM

This revision is now accepted and ready to land.Aug 6 2020, 3:11 PM
This revision was landed with ongoing or failed builds.Aug 6 2020, 3:13 PM
Closed by commit rGce74e97d9b15: [AMDGPU] Correct missing sram-ecc target feature for gfx906 (authored by t-tye). · Explain Why
This revision was automatically updated to reflect the committed changes.
t-tye added a commit: rGce74e97d9b15: [AMDGPU] Correct missing sram-ecc target feature for gfx906.
Harbormaster completed remote builds in B67381: Diff 283743.Aug 6 2020, 3:16 PM

Revision Contents

PathSize
llvm/
docs/
6 lines

Diff 283745

llvm/docs/AMDGPUUsage.rst

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 219 Lines • ▼ Show 20 Lines ``gfx902`` ``amdgcn`` APU - xnack - Ryzen 3 2200G
[on] - Ryzen 5 2400G [on] - Ryzen 5 2400G
``gfx904`` ``amdgcn`` dGPU - xnack *TBA* ``gfx904`` ``amdgcn`` dGPU - xnack *TBA*
[off] [off]
.. TODO:: .. TODO::
Add product Add product
names. names.
``gfx906`` ``amdgcn`` dGPU - xnack - Radeon Instinct MI50 ``gfx906`` ``amdgcn`` dGPU - xnack - Radeon Instinct MI50
[off] - Radeon Instinct MI60 [off] - Radeon Instinct MI60
- Radeon VII - sram-ecc - Radeon VII
- Radeon Pro VII [off] - Radeon Pro VII
``gfx908`` ``amdgcn`` dGPU - xnack *TBA* ``gfx908`` ``amdgcn`` dGPU - xnack *TBA*
[off] [off]
sram-ecc - sram-ecc
[on] [on]
.. TODO:: .. TODO::
Add product Add product
names. names.
``gfx909`` ``amdgcn`` APU - xnack *TBA* ``gfx909`` ``amdgcn`` APU - xnack *TBA*
[on] [on]
.. TODO:: .. TODO::
Add product Add product
▲ Show 20 Lines • Show All 7,583 Lines • Show Last 20 Lines