This is an archive of the discontinued LLVM Phabricator instance.

Differential D85412

[AArch64][NFC] require aarch64 support for hwasan test
ClosedPublic

Authored by sameerds on Aug 6 2020, 1:50 AM.

Details

Reviewers
aemerson
arsenm
danielkiss
eugenis
Commits
rGc530539badd5: [AArch64][NFC] require aarch64 support for hwasan test
Summary

This was breaking builds where the target is not enabled.

Diff Detail

Event Timeline

sameerds created this revision.Aug 6 2020, 1:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2020, 1:50 AM
Herald added subscribers: Restricted Project, danielkiss, kristof.beyls. · View Herald Transcript
sameerds requested review of this revision.Aug 6 2020, 1:50 AM
sameerds added reviewers: aemerson, arsenm.Aug 6 2020, 1:52 AM
Herald added a subscriber: wdng. · View Herald TranscriptAug 6 2020, 1:52 AM
Harbormaster completed remote builds in B67275: Diff 283528.Aug 6 2020, 2:00 AM
danielkiss accepted this revision.Aug 6 2020, 5:03 AM

LGTM

This revision is now accepted and ready to land.Aug 6 2020, 5:03 AM
eugenis accepted this revision.Aug 6 2020, 11:11 AM
eugenis added a subscriber: eugenis.

LGTM

This revision was landed with ongoing or failed builds.Aug 6 2020, 8:56 PM
Closed by commit rGc530539badd5: [AArch64][NFC] require aarch64 support for hwasan test (authored by sameerds). · Explain Why
This revision was automatically updated to reflect the committed changes.
sameerds added a commit: rGc530539badd5: [AArch64][NFC] require aarch64 support for hwasan test.

Revision Contents

PathSize
compiler-rt/
test/
hwasan/
TestCases/
1 line

Diff 283804

compiler-rt/test/hwasan/TestCases/exported-tagged-global.c

// RUN: %clang_hwasan %s -o %t // RUN: %clang_hwasan %s -o %t
// RUN: %run %t // RUN: %run %t
// RUN: %clang_hwasan -O1 %s -o %t // RUN: %clang_hwasan -O1 %s -o %t
// RUN: %run %t // RUN: %run %t
// RUN: %clang_hwasan -O1 -mllvm --aarch64-enable-global-isel-at-O=1 %s -o %t // RUN: %clang_hwasan -O1 -mllvm --aarch64-enable-global-isel-at-O=1 %s -o %t
// RUN: %run %t // RUN: %run %t
// REQUIRES: aarch64-target-arch
static int global; static int global;
__attribute__((optnone)) int *address_of_global() { return &global; } __attribute__((optnone)) int *address_of_global() { return &global; }
int main(int argc, char **argv) { int main(int argc, char **argv) {
int *global_address = address_of_global(); int *global_address = address_of_global();
*global_address = 13; *global_address = 13;
return 0; return 0;
} }