This is an archive of the discontinued LLVM Phabricator instance.

Differential D85362

[CMake] Print the autodetected host linker version
ClosedPublic

Authored by phosek on Aug 5 2020, 2:11 PM.

Details

Reviewers
smeenai
beanz
mcgrathr
Commits
rG633e3dacf27e: [CMake] Print the autodetected host linker version
Summary

There's no easy way to find out what the autodetected version is, but
sometimes it may be useful to confirm that the right version is being
used. Print it as CMake status message.

Diff Detail

Event Timeline

phosek created this revision.Aug 5 2020, 2:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2020, 2:11 PM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
phosek requested review of this revision.Aug 5 2020, 2:11 PM
mcgrathr accepted this revision.Aug 5 2020, 2:12 PM
mcgrathr added a subscriber: mcgrathr.

That's a great start. IMHO we should give the driver a way to print out its embedded value too.

This revision is now accepted and ready to land.Aug 5 2020, 2:12 PM
Harbormaster completed remote builds in B67195: Diff 283393.Aug 5 2020, 3:57 PM
smeenai accepted this revision.Aug 5 2020, 5:57 PM

LGTM

Closed by commit rG633e3dacf27e: [CMake] Print the autodetected host linker version (authored by phosek). · Explain WhyAug 5 2020, 8:23 PM
This revision was automatically updated to reflect the committed changes.
phosek added a commit: rG633e3dacf27e: [CMake] Print the autodetected host linker version.

Revision Contents

PathSize
clang/
14 lines

Diff 283476

clang/CMakeLists.txt

Show First 20 Lines • Show All 418 Lines • ▼ Show 20 Lines
set(HOST_LINK_VERSION) set(HOST_LINK_VERSION)
if (APPLE) if (APPLE)
set(LD_V_OUTPUT) set(LD_V_OUTPUT)
execute_process( execute_process(
COMMAND sh -c "${CMAKE_LINKER} -v 2>&1 | head -1" COMMAND sh -c "${CMAKE_LINKER} -v 2>&1 | head -1"
RESULT_VARIABLE HAD_ERROR RESULT_VARIABLE HAD_ERROR
OUTPUT_VARIABLE LD_V_OUTPUT OUTPUT_VARIABLE LD_V_OUTPUT
) )
if (NOT HAD_ERROR) if (HAD_ERROR)
message(FATAL_ERROR "${CMAKE_LINKER} failed with status ${HAD_ERROR}")
endif()
if ("${LD_V_OUTPUT}" MATCHES ".*ld64-([0-9.]+).*") if ("${LD_V_OUTPUT}" MATCHES ".*ld64-([0-9.]+).*")
string(REGEX REPLACE ".*ld64-([0-9.]+).*" "\\1" HOST_LINK_VERSION ${LD_V_OUTPUT}) string(REGEX REPLACE ".*ld64-([0-9.]+).*" "\\1" HOST_LINK_VERSION ${LD_V_OUTPUT})
elseif ("${LD_V_OUTPUT}" MATCHES "[^0-9]*([0-9.]+).*") elseif ("${LD_V_OUTPUT}" MATCHES "[^0-9]*([0-9.]+).*")
string(REGEX REPLACE "[^0-9]*([0-9.]+).*" "\\1" HOST_LINK_VERSION ${LD_V_OUTPUT}) string(REGEX REPLACE "[^0-9]*([0-9.]+).*" "\\1" HOST_LINK_VERSION ${LD_V_OUTPUT})
endif() endif()
else() message(STATUS "Host linker version: ${HOST_LINK_VERSION}")
message(FATAL_ERROR "${CMAKE_LINKER} failed with status ${HAD_ERROR}")
endif()
endif() endif()
include(CMakeParseArguments) include(CMakeParseArguments)
include(AddClang) include(AddClang)
set(CMAKE_INCLUDE_CURRENT_DIR ON) set(CMAKE_INCLUDE_CURRENT_DIR ON)
include_directories(BEFORE include_directories(BEFORE
▲ Show 20 Lines • Show All 472 Lines • Show Last 20 Lines