This is an archive of the discontinued LLVM Phabricator instance.

[NewPM][LoopUnswitch] Pin loop-unswitch to legacy PM or use simple-loop-unswitch
ClosedPublic

Authored by aeubanks on Aug 5 2020, 1:58 PM.

Details

Summary

As mentioned in
http://lists.llvm.org/pipermail/llvm-dev/2020-July/143395.html,
loop-unswitch has not been ported to the NPM. Instead people are using
simple-loop-unswitch.

Pin all tests in Transforms/LoopUnswitch to legacy PM and replace all
other uses of loop-unswitch with simple-loop-unswitch.

One test that didn't fit into the above was
2014-06-21-congruent-constant.ll which seems to only pass with
loop-unswitch. That is also pinned to legacy PM.

Now all tests containing "-loop-unswitch" anywhere in the test succeed with
NPM turned on by default.

Diff Detail

Event Timeline

aeubanks created this revision.Aug 5 2020, 1:58 PM
aeubanks requested review of this revision.Aug 5 2020, 1:58 PM
ychen accepted this revision.Aug 5 2020, 2:31 PM

Looks good.

This revision is now accepted and ready to land.Aug 5 2020, 2:31 PM
This revision was landed with ongoing or failed builds.Aug 6 2020, 10:56 AM
This revision was automatically updated to reflect the committed changes.