This is an archive of the discontinued LLVM Phabricator instance.

Paths

Refactor: Simplify boolean expression in modularize
ClosedPublic

Authored by LegalizeAdulthood on Mar 22 2015, 1:44 PM.

Reviewers

Commits

Summary

Simplify boolean expressions using true and false with clang-tidy

LegalizeAdulthood retitled this revision from to Refactor: Simplify boolean expression in modularize.

LegalizeAdulthood updated this object.

LegalizeAdulthood edited the test plan for this revision. (Show Details)

LegalizeAdulthood added a subscriber: Unknown Object (MLST).

Looks good, committed in r233000

This revision was automatically updated to reflect the committed changes.

Path

Size

modularize/

2 lines

Show First 20 Lines • Show All 282 Lines • ▼ Show 20 Lines	CoverageChecker::collectUmbrellaHeaderHeaders(StringRef UmbrellaHeaderName) {
std::vector<std::string> HeaderPath;		std::vector<std::string> HeaderPath;
HeaderPath.push_back(UmbrellaHeaderName);		HeaderPath.push_back(UmbrellaHeaderName);

// Create the tool and run the compilation.		// Create the tool and run the compilation.
ClangTool Tool(*Compilations, HeaderPath);		ClangTool Tool(*Compilations, HeaderPath);
int HadErrors = Tool.run(new CoverageCheckerFrontendActionFactory(*this));		int HadErrors = Tool.run(new CoverageCheckerFrontendActionFactory(*this));

// If we had errors, exit early.		// If we had errors, exit early.
return HadErrors ? false : true;		return !HadErrors;
}		}

// Called from CoverageCheckerCallbacks to track a header included		// Called from CoverageCheckerCallbacks to track a header included
// from an umbrella header.		// from an umbrella header.
void CoverageChecker::collectUmbrellaHeaderHeader(StringRef HeaderName) {		void CoverageChecker::collectUmbrellaHeaderHeader(StringRef HeaderName) {

SmallString<256> PathBuf(ModuleMapDirectory);		SmallString<256> PathBuf(ModuleMapDirectory);
// If directory is empty, it's the current directory.		// If directory is empty, it's the current directory.
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines