[Polly] Support linking ScopPassManager against LLVM dylib

[mgorny]

Summary

Link ScopPassManager to LLVM dylib target if LLVM_LINK_LLVM_DYLIB
is enabled. This fixes build failures on systems where static LLVM
libraries are not installed.

[Meinersbur]

polly/unittests/ScopPassManager/CMakeLists.txt

4

Should this depend on LLVM_LINK_LLVM_DYLIB instead?

[mgorny]

Updated to use LLVM_LINK_LLVM_DYLIB.

polly/unittests/ScopPassManager/CMakeLists.txt

4

Sure.

[Meinersbur]

Which configurations have you tested this with?

LLVM_LINK_LLVM_DYLIB is also used in AddLLVM.cmake, but I am not sure how it is propagated in a pre-installed LLVM (i.e. LLVMConfig.cmake).

[mgorny]

In D85281#2196693, @Meinersbur wrote:

Which configurations have you tested this with?

Only Gentoo install. Do you happen to know whom to CC to get better test coverage?

LLVM_LINK_LLVM_DYLIB is also used in AddLLVM.cmake, but I am not sure how it is propagated in a pre-installed LLVM (i.e. LLVMConfig.cmake).

I've grepped it there and it seems to work fine.

[Meinersbur]

In D85281#2196878, @mgorny wrote:

In D85281#2196693, @Meinersbur wrote:

Which configurations have you tested this with?

Only Gentoo install. Do you happen to know whom to CC to get better test coverage?

tHat would probably be me. I am running three Polly buildbots, but we don't have enough resources to test all configurations. Previously, I was testing them manually. See https://groups.google.com/d/msg/polly-dev/vxumPMhrSEs/uE7OfPojCwAJ

LLVM_LINK_LLVM_DYLIB is also used in AddLLVM.cmake, but I am not sure how it is propagated in a pre-installed LLVM (i.e. LLVMConfig.cmake).

I've grepped it there and it seems to work fine.

Asking because there's no LLVM_LINK_LLVM_DYLIB=OFF in my install config without dylib.

polly/unittests/ScopPassManager/CMakeLists.txt

4–9

I think adding libLLVM as dependency is not necessary because if using a dylib, it will be a dependency of Polly anyway.

[mgorny]

Do not add dylib explicitly.

[mgorny]

polly/unittests/ScopPassManager/CMakeLists.txt

4–9

You are indeed correct.

[Meinersbur]

LGTM

[mgorny]

Thanks!

polly/unittests/ScopPassManager/CMakeLists.txt

-llvm_map_components_to_libnames(llvm_libs Passes Core Analysis)
 add_polly_unittest(ScopPassManagerTests
   PassManagerTest.cpp
   )
+if (TARGET LLVM)
+  target_link_libraries(ScopPassManagerTests PRIVATE LLVM)
+else()
+  llvm_map_components_to_libnames(llvm_libs Passes Core Analysis)
   target_link_libraries(ScopPassManagerTests PRIVATE ${llvm_libs})
+endif()