This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] add buffer_atomic_swap for float
ClosedPublic

Authored by ruiling on Aug 4 2020, 2:17 AM.

Details

Summary

The functionality is used when calling imageAtomicExhange() on float
type imageBuffer in Graphics shaders.

Diff Detail

Event Timeline

ruiling created this revision.Aug 4 2020, 2:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2020, 2:17 AM
ruiling requested review of this revision.Aug 4 2020, 2:17 AM
arsenm requested changes to this revision.Aug 4 2020, 5:25 AM

Can you also add a test for the .raw version test

This revision now requires changes to proceed.Aug 4 2020, 5:25 AM
ruiling updated this revision to Diff 282908.Aug 4 2020, 7:01 AM

also add test for .raw version

arsenm accepted this revision.Aug 4 2020, 11:43 AM

Should probably broaden this to all the legal 32-bit types at some point, including <2 x i16> and <2 x half>

This revision is now accepted and ready to land.Aug 4 2020, 11:43 AM
This revision was automatically updated to reflect the committed changes.