This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][builtins] Un-xfail two tests on sparcv9
ClosedPublic

Authored by ro on Aug 3 2020, 4:15 AM.

Details

Summary

Two tests currently XPASS on sparcv9:

Unexpectedly Passed Tests (2):
  Builtins-sparcv9-sunos :: compiler_rt_logbl_test.c
  Builtins-sparcv9-sunos :: divtc3_test.c

The following patch fixes this.

Tested on sparcv9-sun-solaris2.11.

Diff Detail

Event Timeline

ro created this revision.Aug 3 2020, 4:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2020, 4:15 AM
Herald added subscribers: Restricted Project, fedor.sergeev, dberris, jyknight. · View Herald Transcript
ro requested review of this revision.Aug 3 2020, 4:15 AM
ro added a comment.Aug 9 2020, 11:41 PM

Ping? It's been a week.

rupprecht accepted this revision.Aug 10 2020, 8:35 AM

I'm not familiar with sparc target arches, but this looks fine to me if you've been able to verify it fixes things.

This revision is now accepted and ready to land.Aug 10 2020, 8:35 AM
This revision was automatically updated to reflect the committed changes.