This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPSr6] Implement disassembler support
ClosedPublic

Authored by jkolek on Mar 20 2015, 1:01 PM.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 22369.Mar 20 2015, 1:01 PM
jkolek updated this revision to Diff 22370.
jkolek retitled this revision from to [mips][microMIPSr6] Implement disassembler support.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: zoran.jovanovic, dsanders.
jkolek added subscribers: Unknown Object (MLST), petarj.
dsanders added inline comments.Mar 24 2015, 4:27 AM
lib/Target/Mips/Disassembler/MipsDisassembler.cpp
34–35

I'd prefer not to cache flag values from MCSubtargetInfo. Could you do this the way hasMips32r6() does it instead?

I'd appreciate it if you could switch IsMicroMips to that style too (in a separate patch)

jkolek updated this revision to Diff 22572.Mar 24 2015, 7:33 AM
dsanders accepted this revision.Mar 31 2015, 5:31 AM
dsanders edited edge metadata.

LGTM

This revision is now accepted and ready to land.Mar 31 2015, 5:31 AM

Sorry, I think I missed something.

lib/Target/Mips/Disassembler/MipsDisassembler.cpp
828

Do we need both here? I'd expect IsMicroMips to be true when hasMicroMips32r6() is true. It may be better to move the hasMicroMips32r6() check to the else on line 849.

jkolek updated this revision to Diff 23063.Apr 1 2015, 9:07 AM
jkolek edited edge metadata.
jkolek updated this revision to Diff 23218.Apr 3 2015, 6:15 AM
This revision was automatically updated to reflect the committed changes.