Page MenuHomePhabricator

[intel-pt] Simplify Python API configuration

Authored by wallace on Jul 28 2020, 4:25 PM.



Depends on D84791.
The existing way to configure Intel PT tracing through the Python API isn't
trivial. Thus, I'm creating a helper method GetDefaultTraceOptions, which
creates an SBTraceOptions object ready to be used for tracing. This simplifies
the Python code and even some existing C++ code.

Diff Detail

Unit TestsFailed

3,800 mslinux > Clang.OpenMP::declare_mapper_codegen.cpp
Script: -- : 'RUN: at line 8'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/12.0.0/include -nostdsysteminc -DCK0 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple powerpc64le-unknown-unknown -emit-llvm -femit-all-decls -disable-llvm-passes /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/declare_mapper_codegen.cpp -o - | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck --check-prefix CK0 --check-prefix CK0-64 /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/declare_mapper_codegen.cpp
8,650 mslinux > Clang.OpenMP::target_update_codegen.cpp
Script: -- : 'RUN: at line 6'; /mnt/disks/ssd0/agent/llvm-project/build/bin/clang -cc1 -internal-isystem /mnt/disks/ssd0/agent/llvm-project/build/lib/clang/12.0.0/include -nostdsysteminc -DCK1 -verify -fopenmp -fopenmp-targets=powerpc64le-ibm-linux-gnu -x c++ -triple powerpc64le-unknown-unknown -emit-llvm /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/target_update_codegen.cpp -o - | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/clang/test/OpenMP/target_update_codegen.cpp --check-prefix CK1 --check-prefix CK1-64

Event Timeline

wallace created this revision.Jul 28 2020, 4:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 4:25 PM
wallace requested review of this revision.Jul 28 2020, 4:25 PM
wallace abandoned this revision.Aug 3 2020, 3:00 PM

After syncing up with Greg, we decided to redo this in a different way