Page MenuHomePhabricator

[ThinLTO] [test] cache.ll: Prevent Spotlight indexing of the output dir
ClosedPublic

Authored by azharudd on Jul 27 2020, 1:28 PM.

Details

Summary

The test output files whose atime is altered in the test were getting
accessed by Spotlight indexing on macOS, causing them to get an updated
atime and leading to the test not behaving as expected.

Diff Detail

Event Timeline

azharudd created this revision.Jul 27 2020, 1:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 27 2020, 1:28 PM

Since it is just a change in the directory name, I think this would still work fine on other platforms.

steven_wu accepted this revision.Jul 27 2020, 1:56 PM

I have seen that and was wondering why. Thanks for figuring that out!

This revision is now accepted and ready to land.Jul 27 2020, 1:56 PM
jhenderson accepted this revision.Jul 28 2020, 4:21 AM

No issues from my point of view, aside from the suggested comment change.

llvm/test/ThinLTO/X86/cache.ll
4

Since this test isn't macOS specific, perhaps it's best to change this comment to:

"The .noindex suffix for output dir is to prevent Spotlight on MacOS from indexing it."

This revision was landed with ongoing or failed builds.Jul 28 2020, 9:22 PM
This revision was automatically updated to reflect the committed changes.

No issues from my point of view, aside from the suggested comment change.

Done.