Do not return error code, instead return created resource handles or void. Error reporting is done by the library function.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Thanks. I only have a minor nit.
mlir/tools/mlir-rocm-runner/rocm-runtime-wrappers.cpp | ||
---|---|---|
68–69 | should this be void? |
clang-tidy: error: 'cuda.h' file not found [clang-diagnostic-error]
not useful