Page MenuHomePhabricator

Clean up cuda-runtime-wrappers API.
ClosedPublic

Authored by csigg on Jul 27 2020, 7:26 AM.

Details

Summary

Do not return error code, instead return created resource handles or void. Error reporting is done by the library function.

Diff Detail

Event Timeline

csigg created this revision.Jul 27 2020, 7:26 AM
Herald added a project: Restricted Project. · View Herald Transcript
csigg updated this revision to Diff 280916.Jul 27 2020, 7:34 AM

Merge from master.

csigg updated this revision to Diff 280925.Jul 27 2020, 8:17 AM

Fix test.

csigg updated this revision to Diff 280995.Jul 27 2020, 11:38 AM

Rebase from master, fix clang-tidy errors.

herhut accepted this revision.Jul 28 2020, 1:39 AM

Thanks. I only have a minor nit.

mlir/tools/mlir-rocm-runner/rocm-runtime-wrappers.cpp
68–69

should this be void?

This revision is now accepted and ready to land.Jul 28 2020, 1:39 AM
This revision was landed with ongoing or failed builds.Jul 28 2020, 7:34 AM
This revision was automatically updated to reflect the committed changes.