This is an archive of the discontinued LLVM Phabricator instance.

Remove declaration of constexpr member kDynamicSize in MemRefType
ClosedPublic

Authored by mehdi_amini on Jul 26 2020, 9:34 PM.

Details

Summary

This member is already publicly declared on the base class. The
redundant declaration is mangled differently though and in some
unoptimized build it requires a definition to also exist. However we
have a definition for the base ShapedType class, removing the
declaration here will redirect every use to the base class member
instead.

Diff Detail

Event Timeline

mehdi_amini created this revision.Jul 26 2020, 9:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2020, 9:34 PM
jpienaar accepted this revision.Jul 26 2020, 9:47 PM
This revision is now accepted and ready to land.Jul 26 2020, 9:47 PM
This revision was automatically updated to reflect the committed changes.