This is an archive of the discontinued LLVM Phabricator instance.

Differential D84585

Fix a comment error in stack object part
ClosedPublic

Authored by StephenFan on Jul 25 2020, 6:42 AM.

Download Raw Diff

Details

Reviewers

MatzeB
chandlerc
dblaikie
gchatelet

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	140 ms	linux > Polly.ScopInfo::Unknown Unit Message ("")

Event Timeline

StephenFan created this revision.Jul 25 2020, 6:42 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 25 2020, 6:42 AM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Harbormaster failed remote builds in B65690: Diff 280673!Jul 25 2020, 8:04 AM

Sounds good - thanks!

This revision is now accepted and ready to land.Jul 25 2020, 5:36 PM

gchatelet accepted this revision.Jul 27 2020, 12:45 AM

I've submitted it as rG26f1f6d0deaf

Revision Contents

Path

Size

llvm/

include/

llvm/

CodeGen/

MachineFrameInfo.h

2 lines

Diff 280673

llvm/include/llvm/CodeGen/MachineFrameInfo.h

	Show First 20 Lines • Show All 170 Lines • ▼ Show 20 Lines		struct StackObject {
	// Normally, spill slots and fixed-offset objects don't alias IR-accessible			// Normally, spill slots and fixed-offset objects don't alias IR-accessible
	// objects, but there are exceptions (on PowerPC, for example, some byval			// objects, but there are exceptions (on PowerPC, for example, some byval
	// arguments have ABI-prescribed offsets).			// arguments have ABI-prescribed offsets).
	bool isAliased;			bool isAliased;

	/// If true, the object has been zero-extended.			/// If true, the object has been zero-extended.
	bool isZExt = false;			bool isZExt = false;

	/// If true, the object has been zero-extended.			/// If true, the object has been sign-extended.
	bool isSExt = false;			bool isSExt = false;

	uint8_t SSPLayout;			uint8_t SSPLayout;

	StackObject(uint64_t Size, Align Alignment, int64_t SPOffset,			StackObject(uint64_t Size, Align Alignment, int64_t SPOffset,
	bool IsImmutable, bool IsSpillSlot, const AllocaInst *Alloca,			bool IsImmutable, bool IsSpillSlot, const AllocaInst *Alloca,
	bool IsAliased, uint8_t StackID = 0)			bool IsAliased, uint8_t StackID = 0)
	: SPOffset(SPOffset), Size(Size), Alignment(Alignment),			: SPOffset(SPOffset), Size(Size), Alignment(Alignment),
	▲ Show 20 Lines • Show All 650 Lines • Show Last 20 Lines