This is an archive of the discontinued LLVM Phabricator instance.

Differential D84536

[libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows.
ClosedPublic

Authored by dokyungs on Jul 24 2020, 9:20 AM.

Details

Reviewers
morehouse
hctim
kcc
Commits
rG8a4878cc116c: [libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows.
Summary

This patch disables (i) noasan-memcmp64.test on Windows as libFuzzer's interceptors are only supported on Linux for now, and (ii) bcmp.test as on Windows bcmp is not available in strings.h.

Diff Detail

Event Timeline

dokyungs created this revision.Jul 24 2020, 9:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2020, 9:20 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
morehouse accepted this revision.Jul 24 2020, 9:24 AM

Why did the interceptors affect bcmp.test on windows?

This revision is now accepted and ready to land.Jul 24 2020, 9:24 AM
dokyungs added a comment.Jul 24 2020, 9:32 AM
In D84536#2172546, @morehouse wrote:

Why did the interceptors affect bcmp.test on windows?

I am not sure whether libFuzzer's interceptors have affected bcmp.test, because the interceptor library is linked into the executable only when there is no -fsanitize=address. I will investigate further.

dokyungs added a comment.Jul 24 2020, 9:42 AM
In D84536#2172610, @dokyungs wrote:
In D84536#2172546, @morehouse wrote:

Why did the interceptors affect bcmp.test on windows?

I am not sure whether libFuzzer's interceptors have affected bcmp.test, because the interceptor library is linked into the executable only when there is no -fsanitize=address. I will investigate further.

bcmp.test was recently added in f7ffb122d08e7a8203557898c67eaac3a857b152, which implements libFuzzer's interceptor for bcmp. Since bcmp is apparently not available on Windows, I think we can disable this test on Windows.

Closed by commit rG8a4878cc116c: [libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows. (authored by dokyungs). · Explain WhyJul 24 2020, 9:44 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B65582: Diff 280491.Jul 24 2020, 10:32 AM
MaskRay added a subscriber: MaskRay.Jul 24 2020, 10:49 AM
MaskRay added inline comments.
compiler-rt/test/fuzzer/noasan-memcmp64.test
4

I am curious why the suffix -NoAsanMemcmp64BytesTest is needed. Many other tests just use %t

Revision Contents

PathSize
compiler-rt/
test/
fuzzer/
2 lines
4 lines
6 lines

Diff 280491

compiler-rt/test/fuzzer/bcmp.test

UNSUPPORTED: freebsd UNSUPPORTED: freebsd, windows
RUN: %cpp_compiler -DMEMCMP=bcmp %S/MemcmpTest.cpp -o %t RUN: %cpp_compiler -DMEMCMP=bcmp %S/MemcmpTest.cpp -o %t
RUN: not %run %t -seed=1 -runs=10000000 2>&1 | FileCheck %s RUN: not %run %t -seed=1 -runs=10000000 2>&1 | FileCheck %s
CHECK: BINGO CHECK: BINGO

compiler-rt/test/fuzzer/memcmp64.test

UNSUPPORTED: freebsd UNSUPPORTED: freebsd
RUN: %cpp_compiler %S/Memcmp64BytesTest.cpp -o %t-Memcmp64BytesTest RUN: %cpp_compiler %S/Memcmp64BytesTest.cpp -o %t-Memcmp64BytesTest
RUN: not %run %t-Memcmp64BytesTest -seed=1 -runs=1000000 2>&1 | FileCheck %s RUN: not %run %t-Memcmp64BytesTest -seed=1 -runs=1000000 2>&1 | FileCheck %s
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-memcmp %S/Memcmp64BytesTest.cpp -o %t-NoAsanMemcmp64BytesTest
RUN: not %run %t-NoAsanMemcmp64BytesTest -seed=1 -runs=1000000 2>&1 | FileCheck %s
CHECK: BINGO CHECK: BINGO

compiler-rt/test/fuzzer/noasan-memcmp64.test

  • This file was added.
UNSUPPORTED: darwin, freebsd, windows
RUN: %cpp_compiler -fno-sanitize=address -fno-builtin-memcmp %S/Memcmp64BytesTest.cpp -o %t-NoAsanMemcmp64BytesTest
RUN: not %run %t-NoAsanMemcmp64BytesTest -seed=1 -runs=1000000 2>&1 | FileCheck %s
MaskRayUnsubmitted
Not Done
ReplyInline Actions

I am curious why the suffix -NoAsanMemcmp64BytesTest is needed. Many other tests just use %t

MaskRay: I am curious why the suffix `-NoAsanMemcmp64BytesTest` is needed. Many other tests just use `%t`
CHECK: BINGO