Page MenuHomePhabricator

dokyungs (Dokyung Song)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 11 2018, 11:35 PM (108 w, 1 h)

Recent Activity

Tue, Aug 4

dokyungs updated the diff for D84771: [llvm-profdata] Add intersect/exclude subcommands to aid differential code coverage analysis..

Fixed intersect/exclude logic; skip unmatching test profile data.

Tue, Aug 4, 3:19 PM · Restricted Project

Tue, Jul 28

dokyungs updated the summary of D84771: [llvm-profdata] Add intersect/exclude subcommands to aid differential code coverage analysis..
Tue, Jul 28, 2:44 PM · Restricted Project
dokyungs retitled D84771: [llvm-profdata] Add intersect/exclude subcommands to aid differential code coverage analysis. from [llvm-profdata] Add intersect/unique set operators to aid differential code coverage analysis. to [llvm-profdata] Add intersect/exclude subcommands to aid differential code coverage analysis..
Tue, Jul 28, 2:42 PM · Restricted Project
dokyungs updated the diff for D84771: [llvm-profdata] Add intersect/exclude subcommands to aid differential code coverage analysis..

Exit on errors, rename function names, and write comments.

Tue, Jul 28, 2:42 PM · Restricted Project
dokyungs requested review of D84771: [llvm-profdata] Add intersect/exclude subcommands to aid differential code coverage analysis..
Tue, Jul 28, 10:28 AM · Restricted Project

Mon, Jul 27

dokyungs committed rGb52b2e1c1880: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like… (authored by dokyungs).
Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like…
Mon, Jul 27, 11:28 AM
dokyungs added a reverting change for rGf78d9fceea73: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are…: rGb52b2e1c1880: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like….
Mon, Jul 27, 11:28 AM
dokyungs closed D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".
Mon, Jul 27, 11:28 AM · Restricted Project, Restricted Project
dokyungs updated the diff for D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

Disable noasan-bcmp.test on darwin.

Mon, Jul 27, 11:07 AM · Restricted Project, Restricted Project
dokyungs updated the diff for D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

Add '-fno-builtin-bcmp' and a corresponding test case.

Mon, Jul 27, 11:06 AM · Restricted Project, Restricted Project

Fri, Jul 24

dokyungs added a reverting change for rGf78d9fceea73: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are…: D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".
Fri, Jul 24, 9:58 AM
dokyungs added a reverted change for D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.": rGf78d9fceea73: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are….
Fri, Jul 24, 9:58 AM · Restricted Project, Restricted Project
dokyungs updated the diff for D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

Relanding this reverted commit. (See summary)

Fri, Jul 24, 9:58 AM · Restricted Project, Restricted Project
dokyungs reopened D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".
Fri, Jul 24, 9:57 AM · Restricted Project, Restricted Project
dokyungs committed rG8a4878cc116c: [libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows. (authored by dokyungs).
[libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows.
Fri, Jul 24, 9:45 AM
dokyungs closed D84536: [libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows..
Fri, Jul 24, 9:44 AM · Restricted Project
dokyungs added a comment to D84536: [libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows..

Why did the interceptors affect bcmp.test on windows?

I am not sure whether libFuzzer's interceptors have affected bcmp.test, because the interceptor library is linked into the executable only when there is no -fsanitize=address. I will investigate further.

Fri, Jul 24, 9:42 AM · Restricted Project
dokyungs added a comment to D84536: [libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows..

Why did the interceptors affect bcmp.test on windows?

Fri, Jul 24, 9:32 AM · Restricted Project
Herald added a project to D84536: [libFuzzer] Disable noasan-memcmp64.test and bcmp.test on Windows.: Restricted Project.
Fri, Jul 24, 9:20 AM · Restricted Project

Thu, Jul 23

dokyungs committed rG45482367eaf3: [libFuzzer] Add a missing include_directories. (authored by dokyungs).
[libFuzzer] Add a missing include_directories.
Thu, Jul 23, 4:53 PM
dokyungs closed D84474: [libFuzzer] Add a missing include_directories..
Thu, Jul 23, 4:53 PM · Restricted Project
Herald added a project to D84474: [libFuzzer] Add a missing include_directories.: Restricted Project.
Thu, Jul 23, 4:22 PM · Restricted Project
dokyungs added a comment to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

After this commit, several of our builds are failing with FuzzerInterceptors.cpp:30:10: fatal error: 'sanitizer/common_interface_defs.h' file not found. This is odd because the file certainly seems like it exists. Is there a missing include path somewhere, perhaps?

Thu, Jul 23, 3:53 PM · Restricted Project, Restricted Project
dokyungs committed rG769dab207e8b: [libFuzzer] Disable interceptor tests on non-Linux platforms. (authored by dokyungs).
[libFuzzer] Disable interceptor tests on non-Linux platforms.
Thu, Jul 23, 10:23 AM
dokyungs closed D84434: [libFuzzer] Disable interceptor tests on non-Linux platforms..
Thu, Jul 23, 10:23 AM · Restricted Project
dokyungs updated the summary of D84434: [libFuzzer] Disable interceptor tests on non-Linux platforms..
Thu, Jul 23, 10:10 AM · Restricted Project
dokyungs updated the diff for D84434: [libFuzzer] Disable interceptor tests on non-Linux platforms..

Disable all interceptor test cases on non-Linux platforms, since libFuzzer's interceptor support is enabled only on Linux.

Thu, Jul 23, 10:10 AM · Restricted Project
dokyungs added a comment to D84434: [libFuzzer] Disable interceptor tests on non-Linux platforms..

I just realized that NoAsan(Memcmp/Strcmp/Strncmp/Strstr) tests also need disabling, since interceptors right now are only effective on LINUX. I will follow up with an updated patch.

Thu, Jul 23, 9:45 AM · Restricted Project
Herald added a project to D84434: [libFuzzer] Disable interceptor tests on non-Linux platforms.: Restricted Project.
Thu, Jul 23, 9:36 AM · Restricted Project
dokyungs committed rG831ae45e3dc6: Recommit "[libFuzzer] Link libFuzzer's own interceptors when other compiler… (authored by dokyungs).
Recommit "[libFuzzer] Link libFuzzer's own interceptors when other compiler…
Thu, Jul 23, 9:01 AM
dokyungs closed D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Thu, Jul 23, 9:01 AM · Restricted Project, Restricted Project

Wed, Jul 22

dokyungs added inline comments to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Wed, Jul 22, 5:35 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Introduced a helper function to reduce duplicated code.

Wed, Jul 22, 5:33 PM · Restricted Project, Restricted Project
dokyungs added inline comments to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Wed, Jul 22, 2:40 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Introduce internal_strcmp and update tests accordingly.

Wed, Jul 22, 2:38 PM · Restricted Project, Restricted Project

Fri, Jul 17

dokyungs added inline comments to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Fri, Jul 17, 4:26 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Removed CustomAllocatorTest.cpp. Instead, use EmptyTest.cpp.

Fri, Jul 17, 4:05 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Addressed comments.

Fri, Jul 17, 4:03 PM · Restricted Project, Restricted Project
dokyungs updated the summary of D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Fri, Jul 17, 1:45 PM · Restricted Project, Restricted Project
dokyungs updated the summary of D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Fri, Jul 17, 1:44 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Introduce internal_(memcmp|strncmp|strstr) and use them before interceptors are fully initialized.

Fri, Jul 17, 1:33 PM · Restricted Project, Restricted Project
dokyungs reopened D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Fri, Jul 17, 1:30 PM · Restricted Project, Restricted Project

Thu, Jul 16

dokyungs committed rG12d1124c49be: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when… (authored by dokyungs).
[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when…
Thu, Jul 16, 3:55 PM
dokyungs closed D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".
Thu, Jul 16, 3:55 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

Adjusted the comment as suggested.

Thu, Jul 16, 3:10 PM · Restricted Project, Restricted Project
dokyungs added a comment to D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

Thanks Mitch for the comment! Added a comment that explains that.

Thu, Jul 16, 3:01 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".

Addressed comments.

Thu, Jul 16, 3:00 PM · Restricted Project, Restricted Project
dokyungs updated the summary of D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.".
Thu, Jul 16, 2:34 PM · Restricted Project, Restricted Project
Herald added projects to D83987: Recommit "[libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.": Restricted Project, Restricted Project.
Thu, Jul 16, 2:31 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Addressed comments.

Thu, Jul 16, 1:09 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Addressed comments.

Thu, Jul 16, 11:54 AM · Restricted Project, Restricted Project

Wed, Jul 15

dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Ensure the fuzzer RT module is initialized at the beginning of the interceptors.

Wed, Jul 15, 5:34 PM · Restricted Project, Restricted Project

Tue, Jul 14

Herald added a project to D83823: [libFuzzer] Fix compilation error by including missing platform macro definitions.: Restricted Project.
Tue, Jul 14, 3:20 PM · Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Addressed comments.

Tue, Jul 14, 3:13 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83805: [libFuzzer] Separate platform related macros out from FuzzerDefs.h into FuzzerPlatform.h, and adjust includes in other files..

Addressed comments.

Tue, Jul 14, 1:21 PM · Restricted Project
Herald added a project to D83805: [libFuzzer] Separate platform related macros out from FuzzerDefs.h into FuzzerPlatform.h, and adjust includes in other files.: Restricted Project.
Tue, Jul 14, 12:31 PM · Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Use one CHECK for two subtests

Tue, Jul 14, 11:04 AM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Addressed comments.

Tue, Jul 14, 10:54 AM · Restricted Project, Restricted Project
dokyungs added a comment to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Addressed Matt's comments.

A major change in this round that needs explanation is introduction of FuzzerPlatform.h. Previously I defined strstr and strcasestr with extern "C++" to workaround conflicting definition errors resulting from including <string.h>. But since including it is not necessary when compiling this interceptor module, this patch now separates out platform related macros from FuzzerDef.h into FuzzerPlatform.h, and the module includes FuzzerPlatform.h, not FuzzerDef.h.

What was the conflicting definition error? Does string.h have inline definitions for those functions?

Tue, Jul 14, 10:38 AM · Restricted Project, Restricted Project

Mon, Jul 13

dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Use unique output file name for each subtest, and add no-asan subtest in memcmp64.test

Mon, Jul 13, 5:36 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

strncmp test should include -fno-builtin-strncmp, not -fno-builtin-strcmp

Mon, Jul 13, 5:21 PM · Restricted Project, Restricted Project
dokyungs added inline comments to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..
Mon, Jul 13, 5:13 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Addressed Matt's comments.

Mon, Jul 13, 5:09 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Fixed a few LINT warnings by defining some macros that resemble the ones used in other sanitizer interception code.

Mon, Jul 13, 12:25 PM · Restricted Project, Restricted Project
dokyungs added a comment to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Builtin libfunc optimizations may transform memcmp and strcmp-like functions. To disable such optimizations, -fno-builtin= flag was additionally added in compiling new test cases. FWIW, the original test cases didn't require such flags since other sanitizers including ASan disables those optimizations in their LLVM pass by dropping libfunc attribute in the call instructions.

It sounds like we need to add -fno-builtin in the clang driver when building with sancov as well. Otherwise, users won't get any benefit of this patch without doing clang++ -fsanitize=fuzzer my_fuzz_target.cpp -fno-builtin-strstr -fno-builtin-strncmp -fno-builtin-strcmp -fno-builtin-memcmp?

Mon, Jul 13, 12:08 PM · Restricted Project, Restricted Project
dokyungs updated the diff for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked..

Add interceptors for all the functions libFuzzer has a weak interceptor for, and duplicate existing interceptor test cases with new compiler flags (-fno-sanitize=address).

Mon, Jul 13, 9:31 AM · Restricted Project, Restricted Project

Fri, Jul 10

dokyungs updated the summary of D83593: [compiler-rt] Fix compiler warnings and runtime errors in sanitizer RT strxfrm(_l) test cases..
Fri, Jul 10, 4:17 PM · Restricted Project
Herald added a project to D83593: [compiler-rt] Fix compiler warnings and runtime errors in sanitizer RT strxfrm(_l) test cases.: Restricted Project.
Fri, Jul 10, 3:46 PM · Restricted Project

Thu, Jul 9

dokyungs added reviewers for D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.: kcc, morehouse, hctim.
Thu, Jul 9, 10:39 AM · Restricted Project, Restricted Project
Herald added projects to D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.: Restricted Project, Restricted Project.
Thu, Jul 9, 10:34 AM · Restricted Project, Restricted Project