Page MenuHomePhabricator

[mlir][Linalg] Fixing bug in subview size computation in Linalg tiling.

Authored by mravishankar on Jul 22 2020, 4:24 PM.



The makeTiledViews did not use the sizes of the tiled views based on
the result of the loop bound inference computation. This manifested as
an error in computing tile sizes with convolution where not all the
result expression of concatenated affine maps are simple

Diff Detail

Unit TestsFailed

40 mslinux > MLIR.Dialect/Linalg::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/bin/mlir-opt /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/tile_simple_conv.mlir -linalg-tile="linalg-tile-sizes=2,3,4" | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/mlir/test/Dialect/Linalg/tile_simple_conv.mlir
60 mswindows > MLIR.Dialect/Linalg::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; c:\ws\w1\llvm-project\premerge-checks\build\bin\mlir-opt.exe C:\ws\w1\llvm-project\premerge-checks\mlir\test\Dialect\Linalg\tile_simple_conv.mlir -linalg-tile="linalg-tile-sizes=2,3,4" | c:\ws\w1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w1\llvm-project\premerge-checks\mlir\test\Dialect\Linalg\tile_simple_conv.mlir

Event Timeline

mravishankar created this revision.Jul 22 2020, 4:24 PM
This revision is now accepted and ready to land.Jul 22 2020, 10:43 PM

Fixing test run error

This revision was automatically updated to reflect the committed changes.