Adding Pass Dependencies for CodeGenPrepare

[AndrewLitteken]

Summary

When adding a pass to the pipeline, there would be differences between in the generated code when the pass performed no operations, and when the pass was not present.

This pass adds dependencies for

• TargetTransformInfoWrapperPass
• TargetPassConfig
• LoopInfoWrapperPass
• TargetLibraryInfoWrapperPass

which are used but did not were not recorded using the INITIALIZE_PASS_DEPENDENCY macro to fix this inconsistency.

[efriedma]

LGTM with one minor comment

llvm/lib/CodeGen/CodeGenPrepare.cpp

446

Can you alphabetize these?

[AndrewLitteken]

Alphabetizing pass dependencies

llvm/lib/CodeGen/CodeGenPrepare.cpp

class TypePromotionTransaction;
   };
 
 } // end anonymous namespace
 
 char CodeGenPrepare::ID = 0;
 
 INITIALIZE_PASS_BEGIN(CodeGenPrepare, DEBUG_TYPE,
                       "Optimize for code generation", false, false)
+INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(ProfileSummaryInfoWrapperPass)
+INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
+INITIALIZE_PASS_DEPENDENCY(TargetPassConfig)
+INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
 INITIALIZE_PASS_END(CodeGenPrepare, DEBUG_TYPE,
                     "Optimize for code generation", false, false)
 
 FunctionPass *llvm::createCodeGenPreparePass() { return new CodeGenPrepare(); }
 
 bool CodeGenPrepare::runOnFunction(Function &F) {
   if (skipFunction(F))
     return false;