This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Don't assert on f16 inv2pi immediates pre-gfx8
ClosedPublic

Authored by arsenm on Jul 22 2020, 9:35 AM.

Reviewers

Summary

v_cvt_f32_f16 can still accept this value as a literal constant. This
showed up in GlobalISel since it doesn't have constant folding for
G_FPEXT.

LGTM

This revision is now accepted and ready to land.Jul 22 2020, 10:36 AM

Path

Size

llvm/

lib/

Target/

AMDGPU/

MCTargetDesc/

4 lines

test/

MC/

AMDGPU/

10 lines

Show First 20 Lines • Show All 416 Lines • ▼ Show 20 Lines	void AMDGPUInstPrinter::printImmediate16(uint32_t Imm,
else if (Imm == 0x4000)		else if (Imm == 0x4000)
O<< "2.0";		O<< "2.0";
else if (Imm == 0xC000)		else if (Imm == 0xC000)
O<< "-2.0";		O<< "-2.0";
else if (Imm == 0x4400)		else if (Imm == 0x4400)
O<< "4.0";		O<< "4.0";
else if (Imm == 0xC400)		else if (Imm == 0xC400)
O<< "-4.0";		O<< "-4.0";
else if (Imm == 0x3118) {		else if (Imm == 0x3118 &&
assert(STI.getFeatureBits()[AMDGPU::FeatureInv2PiInlineImm]);		STI.getFeatureBits()[AMDGPU::FeatureInv2PiInlineImm]) {
O << "0.15915494";		O << "0.15915494";
} else		} else
O << formatHex(static_cast<uint64_t>(Imm));		O << formatHex(static_cast<uint64_t>(Imm));
}		}

void AMDGPUInstPrinter::printImmediateV216(uint32_t Imm,		void AMDGPUInstPrinter::printImmediateV216(uint32_t Imm,
const MCSubtargetInfo &STI,		const MCSubtargetInfo &STI,
raw_ostream &O) {		raw_ostream &O) {
▲ Show 20 Lines • Show All 1,177 Lines • Show Last 20 Lines

				// RUN: llvm-mc -arch=amdgcn -mcpu=tahiti -show-encoding %s \| FileCheck -check-prefix=SI %s
				// RUN: llvm-mc -arch=amdgcn -mcpu=tonga -show-encoding %s \| FileCheck -check-prefix=VI %s

				// The value inv2pi should not assert on any targets, but is
				// printed differently depending on whether it's a legal inline
				// immediate or not.

				// SI: v_cvt_f32_f16_e32 v0, 0x3118 ; encoding: [0xff,0x16,0x00,0x7e,0x18,0x31,0x00,0x00]
				// VI: v_cvt_f32_f16_e32 v0, 0.15915494 ; encoding: [0xf8,0x16,0x00,0x7e]
				v_cvt_f32_f16_e32 v0, 0x3118