This is an archive of the discontinued LLVM Phabricator instance.

[test-release] fallback to py3's venv module
AcceptedPublic

Authored by bcain on Jul 16 2020, 3:02 PM.

Details

Reviewers
hans
rovka
dim
ro
Summary

If virtualenv is not available, we can look for py3's venv instead. We only use this particular env for installing and running the test suite.

Diff Detail

Event Timeline

bcain created this revision.Jul 16 2020, 3:02 PM

I created this to make it easier to run builds on systems that have python3 but don't have virtualenv installed. python3 comes with venv.

https://docs.python.org/3/library/venv.html says that at one time pyvenv was recommended but that was deprecated in favor of "python3 -m venv" which works very similar to virtualenv.

bcain updated this revision to Diff 278612.Jul 16 2020, 3:05 PM

updated diff w/context

dim accepted this revision.Jul 16 2020, 3:29 PM

LGTM.

This revision is now accepted and ready to land.Jul 16 2020, 3:29 PM
hans added inline comments.Jul 17 2020, 2:11 AM
llvm/utils/release/test-release.sh
309

Should this be inside an if [ $do_test_suite = "yes" ]; ?

I think virtualenv is only used for test_suite.

bcain marked an inline comment as done.Jul 17 2020, 7:28 AM
bcain added inline comments.
llvm/utils/release/test-release.sh
309

Should this be inside an if [ $do_test_suite = "yes" ]; ?

I think virtualenv is only used for test_suite.

Yes, that seems right. I will change it.

bcain updated this revision to Diff 278785.Jul 17 2020, 8:30 AM
hans added inline comments.Jul 17 2020, 9:36 AM
llvm/utils/release/test-release.sh
502

I think this would be a better place to set up ${venv} (more related to test-suite) than in export_sources()

bcain updated this revision to Diff 279272.Jul 20 2020, 9:12 AM
hans accepted this revision.Jul 20 2020, 9:41 AM

lgtm, thanks!

ro resigned from this revision.Aug 6 2020, 8:51 AM
hans added a comment.Aug 7 2020, 10:24 AM

Brian: I think this is good to go, right?