This is an archive of the discontinued LLVM Phabricator instance.

[llvm][NFC] Hide the tensorflow dependency from headers.
ClosedPublic

Authored by mtrofin on Jul 14 2020, 7:39 PM.

Details

Summary

This change avoids exposing tensorflow types when including TFUtils.h.
They are just an implementation detail, and don't need to be used
directly when implementing an analysis requiring ML model evaluation.

The TFUtils APIs, while generically typed, are still not exposed unless
the tensorflow C library is present, as they currently have no use
otherwise.

Diff Detail

Event Timeline

mtrofin created this revision.Jul 14 2020, 7:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2020, 7:39 PM
mehdi_amini accepted this revision.Jul 14 2020, 7:48 PM

Already done? You're really fast!
Thanks :)

This revision is now accepted and ready to land.Jul 14 2020, 7:48 PM
This revision was automatically updated to reflect the committed changes.
mtrofin marked an inline comment as done.Jul 14 2020, 9:19 PM
mtrofin added inline comments.
llvm/lib/Analysis/TFUtils.cpp
92

Ugh - just saw this one (the others are spurious). I'll rename it shortly.