This is an archive of the discontinued LLVM Phabricator instance.

Differential D83761

Fix broken HUGE_VALF macro in llvm-c/DataTypes.h
ClosedPublic

Authored by teemperor on Jul 14 2020, 4:35 AM.

Details

Reviewers
rnk
thakis
JDevlieghere
deadalnix
Commits
rG9124fa592098: Fix broken HUGE_VALF macro in llvm-c/DataTypes.h
Summary

Commit 3a29393b4709d15069130119cf1d136af4a92d77 removes the cmath/math.h includes
from the DataTypes.h header to speed up parsing. However the DataTypes.h header was using
this header to get the macro HUGE_VAL for its own HUGE_VALF macro definition. Now
the macro instead just expands into a plain HUGE_VAL token which leads to compiler errors
unless math.h was previously included by the including source file. It also leads to compiler
warnings with enabled module builds which point out this inconsistency.

The correct way to fix this seems to be to just remove HUGE_VALF from the header. llvm-c
is not referencing that macro from what I can see and users probably should just include
the math headers if they need it (or define it on their own for really old C versions).

Diff Detail

Event Timeline

teemperor created this revision.Jul 14 2020, 4:35 AM
Herald added a reviewer: deadalnix. · View Herald TranscriptJul 14 2020, 4:35 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
teemperor added a comment.Jul 14 2020, 4:53 AM

@rnk seems OOO but he did the original change, so I just added a bunch of other folks who could review this.

Harbormaster failed remote builds in B64133: Diff 277773!Jul 14 2020, 5:56 AM
JDevlieghere accepted this revision.Jul 14 2020, 9:44 AM

Another alternative would be to check if HUGE_VAL is defined, but if I agree that if it's not used it should just go.

This revision is now accepted and ready to land.Jul 14 2020, 9:44 AM
This revision was landed with ongoing or failed builds.Sep 3 2020, 12:50 AM
Closed by commit rG9124fa592098: Fix broken HUGE_VALF macro in llvm-c/DataTypes.h (authored by teemperor). · Explain Why
This revision was automatically updated to reflect the committed changes.
teemperor added a commit: rG9124fa592098: Fix broken HUGE_VALF macro in llvm-c/DataTypes.h.

Revision Contents

PathSize
llvm/
include/
llvm-c/
4 lines

Diff 289650

llvm/include/llvm-c/DataTypes.h

Show First 20 Lines • Show All 71 Lines • ▼ Show 20 Lines
#endif #endif
#if !defined(INT64_MIN) #if !defined(INT64_MIN)
# define INT64_MIN ((-INT64_MAX)-1) # define INT64_MIN ((-INT64_MAX)-1)
#endif #endif
#if !defined(UINT64_MAX) #if !defined(UINT64_MAX)
# define UINT64_MAX 0xffffffffffffffffULL # define UINT64_MAX 0xffffffffffffffffULL
#endif #endif
#ifndef HUGE_VALF
#define HUGE_VALF (float)HUGE_VAL
#endif
#endif /* LLVM_C_DATATYPES_H */ #endif /* LLVM_C_DATATYPES_H */