This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Config: CompileFlags.Remove
ClosedPublic

Authored by sammccall on Jul 13 2020, 11:38 AM.

Details

Summary

While here, add documentation to CompileFlags and CompileFlags.Add.

Diff Detail

Event Timeline

sammccall created this revision.Jul 13 2020, 11:38 AM
hokein accepted this revision.Jul 14 2020, 12:19 AM
hokein added inline comments.
clang-tools-extra/clangd/ConfigCompile.cpp
126

the order of processing "Remove" and "Add" matters, if they are conflict, the Add will take precedence, I think this is intended? Maybe worth clarifying in the CompileFlagsBlock comments.

clang-tools-extra/clangd/ConfigFragment.h
136

nit: wil => will

141

nit: I'd prefer to give a few concrete examples (e.g. examples I mentioned in another patch), it would be helpful for readers to understand.

This revision is now accepted and ready to land.Jul 14 2020, 12:19 AM
sammccall marked 3 inline comments as done.Jul 14 2020, 6:56 AM
This revision was automatically updated to reflect the committed changes.