This is an archive of the discontinued LLVM Phabricator instance.

[AVRInstPrinter] printOperand: support llvm-objdump --print-imm-hex
ClosedPublic

Authored by MaskRay on Jul 11 2020, 5:07 PM.

Diff Detail

Event Timeline

MaskRay created this revision.Jul 11 2020, 5:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2020, 5:07 PM
MaskRay updated this revision to Diff 277268.Jul 11 2020, 5:08 PM

Forgot to add test

aykevl added a comment.EditedJul 12 2020, 3:04 AM

Looks good to me. I've confirmed this works with D78741 and I have updated the patch to make use of it.

Looks good to me. I've confirmed this works with D78741 and I have updated the patch to make use of it.

Thanks. I'll push this to unblock D78741.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 12 2020, 8:15 AM
This revision was automatically updated to reflect the committed changes.

Thanks. I'll push this to unblock D78741.

Awesome, thank you! I merged that change as well so LLVM 11 should get AVR lld support.