This is an archive of the discontinued LLVM Phabricator instance.

Add missing CMake bool canonicalizations.
ClosedPublic

Authored by stellaraccident on Jul 8 2020, 8:01 PM.

Reviewers

stephenneuendorffer
mehdi_amini

Commits

rGabd6574b4542: Add missing CMake bool canonicalizations.

Summary

This allows these flags to be passed on the command line with normal CMake bool-interpreted values like ON/OFF instead of requiring 0/1.
As-is, if passing ON/OFF, these will cause a parse error in lit.site.cfg.py because Python tries to interpret the string literally.

This revision is now accepted and ready to land.Jul 8 2020, 8:10 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

mlir/

test/

5 lines

	add_subdirectory(EDSC)			add_subdirectory(EDSC)
	add_subdirectory(mlir-cpu-runner)			add_subdirectory(mlir-cpu-runner)
	add_subdirectory(SDBM)			add_subdirectory(SDBM)
	add_subdirectory(lib)			add_subdirectory(lib)

	llvm_canonicalize_cmake_booleans(			llvm_canonicalize_cmake_booleans(
	LLVM_BUILD_EXAMPLES			LLVM_BUILD_EXAMPLES
				MLIR_CUDA_CONVERSIONS_ENABLED
				MLIR_CUDA_RUNNER_ENABLED
				MLIR_ROCM_CONVERSIONS_ENABLED
				MLIR_ROCM_RUNNER_ENABLED
				MLIR_VULKAN_RUNNER_ENABLED
	)			)

	# Passed to lit.site.cfg.py.in to set up the path where to find the libraries			# Passed to lit.site.cfg.py.in to set up the path where to find the libraries
	# for linalg integration tests.			# for linalg integration tests.
	set(MLIR_DIALECT_LINALG_INTEGRATION_TEST_LIB_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})			set(MLIR_DIALECT_LINALG_INTEGRATION_TEST_LIB_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})
	set(MLIR_RUNNER_UTILS_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})			set(MLIR_RUNNER_UTILS_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY})

	# Passed to lit.site.cfg.py.in to set up the path where to find the libraries			# Passed to lit.site.cfg.py.in to set up the path where to find the libraries
	▲ Show 20 Lines • Show All 74 Lines • Show Last 20 Lines