This is an archive of the discontinued LLVM Phabricator instance.

[test] Run llvm/test/**/*.yaml & don't run llvm/test/**/*.cxx (not exist)
ClosedPublic

Authored by MaskRay on Jul 7 2020, 3:20 PM.

Details

Summary

This patch extends D58439 (llvm/test/{yaml2obj,obj2yaml}/**/*.yaml) and runs all
llvm/test/**/*.yaml

Many directories have configured .yaml (see the deleted lit.local.cfg
files). Yet still some don't configure .yaml and have caused stale tests:

Just hoist .yaml to llvm/test/lit.cfg.py. Also delete .cxx which is
not used. The number of tests running on my machine increases from 38304 to 38309.
The list of new tests:

ExecutionEngine/RuntimeDyld/X86/ELF_x86-64_none.yaml
Object/archive-error-tmp.txt
tools/llvm-ar/coff-weak.yaml
tools/llvm-readobj/ELF/verneed-flags.yaml
tools/obj2yaml/COFF/bss.s

Diff Detail

Event Timeline

MaskRay created this revision.Jul 7 2020, 3:20 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2020, 3:20 PM
MaskRay updated this revision to Diff 276233.Jul 7 2020, 3:23 PM
MaskRay edited the summary of this revision. (Show Details)

Delete .cxx (there is no such test)

rupprecht accepted this revision.Jul 7 2020, 4:16 PM

Good catch

This revision is now accepted and ready to land.Jul 7 2020, 4:16 PM
Harbormaster failed remote builds in B63310: Diff 276233!
jhenderson accepted this revision.Jul 8 2020, 12:12 AM

LGTM. For my sanity, can you confirm which the five new tests are that you are running?

grimar accepted this revision.Jul 8 2020, 1:39 AM

LGTM, cool! Since you are removing .cxx, it probably worth mentioning in the patch header (in theory it might be used in downstream builds).

MaskRay retitled this revision from [test] Run llvm/test/**/*.yaml to [test] Run llvm/test/**/*.yaml & don't run llvm/test/**/*.cxx (not exist).Jul 8 2020, 10:22 AM
MaskRay edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
llvm/test/tools/llvm-objdump/lit.local.cfg