This is an archive of the discontinued LLVM Phabricator instance.

[PGO][PGSO] Add profile guided size optimization to X86ISelDAGToDAG.
ClosedPublic

Authored by hjyamauchi on Jul 7 2020, 11:36 AM.

Diff Detail

Event Timeline

hjyamauchi created this revision.Jul 7 2020, 11:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 7 2020, 11:36 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
craig.topper added inline comments.Jul 7 2020, 2:35 PM
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
165

ARe more changes needed to get rid of this member?

Turn OptForSize into a local variable.

hjyamauchi marked an inline comment as done.Jul 8 2020, 12:23 PM
hjyamauchi added inline comments.
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
165

The only remaining use is for the "OptForMinSize implies OptForSize" assert in runOnMachineFunction.

I turned into a local variable there to keep the assert.

We could also remove it along with the assert if it'd be better that way.

More comments?

This revision is now accepted and ready to land.Jul 10 2020, 10:11 AM
This revision was automatically updated to reflect the committed changes.