This is an archive of the discontinued LLVM Phabricator instance.

Differential D83237

[flang] Add missing include for std::min
ClosedPublic

Authored by tskeith on Jul 6 2020, 9:19 AM.

Details

Reviewers
klausler
jdoerfert
DavidTruby
Commits
rG1b183918184e: [flang] Add missing include for std::min
Summary

This was causing the build to fail on macos.

Diff Detail

Event Timeline

tskeith created this revision.Jul 6 2020, 9:19 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJul 6 2020, 9:19 AM
Herald added a reviewer: DavidTruby. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: llvm-commits. · View Herald Transcript
DavidTruby accepted this revision.Jul 6 2020, 9:21 AM

We must have overlapped here somehow, I actually created a revision for this a couple of hours ago
https://reviews.llvm.org/D83227

I'm happy to LGTM this as it is identical to my patch

This revision is now accepted and ready to land.Jul 6 2020, 9:21 AM
Harbormaster completed remote builds in B63033: Diff 275734.Jul 6 2020, 9:42 AM
klausler accepted this revision.Jul 6 2020, 12:58 PM
Closed by commit rG1b183918184e: [flang] Add missing include for std::min (authored by tskeith). · Explain WhyJul 6 2020, 1:03 PM
This revision was automatically updated to reflect the committed changes.
tskeith added a comment.Jul 6 2020, 1:04 PM
In D83237#2133321, @DavidTruby wrote:

We must have overlapped here somehow, I actually created a revision for this a couple of hours ago
https://reviews.llvm.org/D83227

Thanks. Phabricator seems very erratic with email. I only received yours a few minutes ago.

Revision Contents

PathSize
flang/
runtime/
1 line

Diff 275813

flang/runtime/file.cpp

//===-- runtime/file.cpp ----------------------------------------*- C++ -*-===// //===-- runtime/file.cpp ----------------------------------------*- C++ -*-===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#include "file.h" #include "file.h"
#include "magic-numbers.h" #include "magic-numbers.h"
#include "memory.h" #include "memory.h"
#include <algorithm>
#include <cerrno> #include <cerrno>
#include <cstring> #include <cstring>
#include <fcntl.h> #include <fcntl.h>
#include <stdlib.h> #include <stdlib.h>
#ifdef _WIN32 #ifdef _WIN32
#include <io.h> #include <io.h>
#include <windows.h> #include <windows.h>
#else #else
▲ Show 20 Lines • Show All 342 Lines • Show Last 20 Lines