Avoid using globals in ELF Symbol Table

[wsmoses]

Summary

The Symbol Table in LLD references the global object to add a symbol rather than adding it to itself.

[MaskRay]

Thanks! This may have a minor performance increase.

[MaskRay]

I can commit the for you if you don't have commit access. Please provide Name <email> so that you can get proper credit.

[wsmoses]

In D83184#2133678, @MaskRay wrote:

I can commit the for you if you don't have commit access. Please provide Name <email> so that you can get proper credit.

I do not presently have commit access, for my git commits I use:
William S. Moses <[e-mail]>

Thanks!

lld/ELF/SymbolTable.cpp

Symbol *SymbolTable::insert(StringRef name) {
   sym->referenced = false;
   sym->traced = false;
   sym->scriptDefined = false;
   sym->partition = 1;
   return sym;
 }
 
 Symbol *SymbolTable::addSymbol(const Symbol &newSym) {
-  Symbol *sym = symtab->insert(newSym.getName());
+  Symbol *sym = insert(newSym.getName());
   sym->resolve(newSym);
   return sym;
 }
 
 Symbol *SymbolTable::find(StringRef name) {
   auto it = symMap.find(CachedHashStringRef(name));
   if (it == symMap.end())
     return nullptr;