[clang-tidy] Fix hicpp-named-paramater

[njames93]

Summary

Currently this alias instantiates the readability-identifier-naming check, just swap it out to use the readability-named-paramater check.

[aaron.ballman]

I do not understand the justification here -- IdentifierNamingCheck and NamedParameterCheck are two different checks. How do you know that this swap continues to honor the HIC++ coding standard?

[njames93]

In D82711#2119651, @aaron.ballman wrote:

I do not understand the justification here -- IdentifierNamingCheck and NamedParameterCheck are two different checks. How do you know that this swap continues to honor the HIC++ coding standard?

Because thats what the documentation says
In docs/checks/hicpp-named-paramater.rst:

hicpp-named-parameter
This check is an alias for readability-named-parameter.

Implements rule 8.2.1.

From https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard/definitions:

8.2.1 Make parameter names absent or identical in all declarations

Its fairly obvious this has been incorrect since its inception. Arguable readability-named-paramater doesn't quite cover the extent of the HIC++ coding standard, but it goes a lot further than the identifier-naming-check does.

EDIT: Down the line I may create a check that fully enforces rule 8.2.1, but for now this is a good small step

[aaron.ballman]

In D82711#2119714, @njames93 wrote:

In D82711#2119651, @aaron.ballman wrote:

I do not understand the justification here -- IdentifierNamingCheck and NamedParameterCheck are two different checks. How do you know that this swap continues to honor the HIC++ coding standard?

Because thats what the documentation says
In docs/checks/hicpp-named-paramater.rst:

hicpp-named-parameter
This check is an alias for readability-named-parameter.

Implements rule 8.2.1.

From https://www.perforce.com/resources/qac/high-integrity-cpp-coding-standard/definitions:

8.2.1 Make parameter names absent or identical in all declarations

Its fairly obvious this has been incorrect since its inception. Arguable readability-named-paramater doesn't quite cover the extent of the HIC++ coding standard, but it goes a lot further than the identifier-naming-check does.

Oof! Good catch! Thanks for the explanation, I was missing that bit.

EDIT: Down the line I may create a check that fully enforces rule 8.2.1, but for now this is a good small step

Agreed. LGTM

clang-tools-extra/clang-tidy/hicpp/HICPPTidyModule.cpp

 //===------- HICPPTidyModule.cpp - clang-tidy -----------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "../ClangTidy.h"
 #include "../ClangTidyModule.h"
 #include "../ClangTidyModuleRegistry.h"
+#include "../bugprone/UndelegatedConstructorCheck.h"
 #include "../bugprone/UseAfterMoveCheck.h"
 #include "../cppcoreguidelines/AvoidGotoCheck.h"
 #include "../cppcoreguidelines/NoMallocCheck.h"
 #include "../cppcoreguidelines/ProBoundsArrayToPointerDecayCheck.h"
 #include "../cppcoreguidelines/ProTypeMemberInitCheck.h"
 #include "../cppcoreguidelines/ProTypeVarargCheck.h"
 #include "../cppcoreguidelines/SpecialMemberFunctionsCheck.h"
 #include "../google/DefaultArgumentsCheck.h"
 #include "../google/ExplicitConstructorCheck.h"
 #include "../misc/NewDeleteOverloadsCheck.h"
 #include "../misc/StaticAssertCheck.h"
-#include "../bugprone/UndelegatedConstructorCheck.h"
 #include "../modernize/AvoidCArraysCheck.h"
 #include "../modernize/DeprecatedHeadersCheck.h"
 #include "../modernize/UseAutoCheck.h"
 #include "../modernize/UseEmplaceCheck.h"
 #include "../modernize/UseEqualsDefaultCheck.h"
 #include "../modernize/UseEqualsDeleteCheck.h"
 #include "../modernize/UseNoexceptCheck.h"
 #include "../modernize/UseNullptrCheck.h"
 #include "../modernize/UseOverrideCheck.h"
 #include "../performance/MoveConstArgCheck.h"
 #include "../performance/NoexceptMoveConstructorCheck.h"
 #include "../readability/BracesAroundStatementsCheck.h"
 #include "../readability/FunctionSizeCheck.h"
-#include "../readability/IdentifierNamingCheck.h"
+#include "../readability/NamedParameterCheck.h"
 #include "../readability/UppercaseLiteralSuffixCheck.h"
 #include "ExceptionBaseclassCheck.h"
 #include "MultiwayPathsCoveredCheck.h"
 #include "NoAssemblerCheck.h"
 #include "SignedBitwiseCheck.h"
 
 namespace clang {
 namespace tidy {
CheckFactories.registerCheck<ExceptionBaseclassCheck>(
         "hicpp-exception-baseclass");
     CheckFactories.registerCheck<MultiwayPathsCoveredCheck>(
         "hicpp-multiway-paths-covered");
     CheckFactories.registerCheck<SignedBitwiseCheck>("hicpp-signed-bitwise");
     CheckFactories.registerCheck<google::ExplicitConstructorCheck>(
         "hicpp-explicit-conversions");
     CheckFactories.registerCheck<readability::FunctionSizeCheck>(
         "hicpp-function-size");
-    CheckFactories.registerCheck<readability::IdentifierNamingCheck>(
+    CheckFactories.registerCheck<readability::NamedParameterCheck>(
         "hicpp-named-parameter");
     CheckFactories.registerCheck<bugprone::UseAfterMoveCheck>(
         "hicpp-invalid-access-moved");
     CheckFactories.registerCheck<cppcoreguidelines::ProTypeMemberInitCheck>(
         "hicpp-member-init");
     CheckFactories.registerCheck<performance::MoveConstArgCheck>(
         "hicpp-move-const-arg");
     CheckFactories.registerCheck<misc::NewDeleteOverloadsCheck>(