[Hexagon][NFC] Remove redundant condition

[baloghadamsoftware]

Summary

Condition secondReg is checked both in an outer and in an inner if statement in static function canCompareBeNewValueJump() in file HexagonNewValueJump.cpp. This patch removes the redundant inner check.

The issue was found using clang-tidy check under review misc-redundant-condition. See https://reviews.llvm.org/D81272.

llvm/lib/Target/Hexagon/HexagonNewValueJump.cpp

if (secondReg) {
     // value compare. Only one operand may use the .new suffix.
     if (cmpReg1 == cmpOp2)
       return false;
 
     // Make sure that the second register is not from COPY
     // at machine code level, we don't need this, but if we decide
     // to move new value jump prior to RA, we would be needing this.
     MachineRegisterInfo &MRI = MF.getRegInfo();
-    if (secondReg && !Register::isPhysicalRegister(cmpOp2)) {
+    if (!Register::isPhysicalRegister(cmpOp2)) {
       MachineInstr *def = MRI.getVRegDef(cmpOp2);
       if (def->getOpcode() == TargetOpcode::COPY)
         return false;
     }
   }
 
   // Walk the instructions after the compare (predicate def) to the jump,
   // and satisfy the following conditions.