This is an archive of the discontinued LLVM Phabricator instance.

[FileCheck][NFC] Remove redundant DumpInputDefault
ClosedPublic

Authored by jdenny on Jun 24 2020, 9:57 AM.

Reviewers

Commits

Summary

I cannot find a reason to keep DumpInputDefault. Anyone else?

This revision is now accepted and ready to land.Jun 24 2020, 8:30 PM

Any change of getting this with the context included? I'm guessing it's fine, but it's a little hard to check without.

Ah, sorry I forgot to include context. Fixed.

LGTM too.

Thanks!

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

utils/

FileCheck/

6 lines

Context not available.
	// The order of DumpInputValue members affects their precedence, as documented	// The order of DumpInputValue members affects their precedence, as documented
	// for -dump-input below.	// for -dump-input below.
	enum DumpInputValue {	enum DumpInputValue {
	DumpInputDefault,
	DumpInputNever,	DumpInputNever,
	DumpInputFail,	DumpInputFail,
	DumpInputAlways,	DumpInputAlways,
Context not available.
	"FILECHECK_OPTS");	"FILECHECK_OPTS");
	DumpInputValue DumpInput =	DumpInputValue DumpInput =
	DumpInputs.empty()	DumpInputs.empty()
	? DumpInputDefault	? DumpInputFail
	: *std::max_element(DumpInputs.begin(), DumpInputs.end());	: *std::max_element(DumpInputs.begin(), DumpInputs.end());
	if (DumpInput == DumpInputHelp) {	if (DumpInput == DumpInputHelp) {
	DumpInputAnnotationHelp(outs());	DumpInputAnnotationHelp(outs());
Context not available.
	InputFileText, InputFile.getBufferIdentifier()),	InputFileText, InputFile.getBufferIdentifier()),
	SMLoc());	SMLoc());

	if (DumpInput == DumpInputDefault)
	DumpInput = DumpInputFail;

	std::vector<FileCheckDiag> Diags;	std::vector<FileCheckDiag> Diags;
	int ExitCode = FC.checkInput(SM, InputFileText,	int ExitCode = FC.checkInput(SM, InputFileText,
	DumpInput == DumpInputNever ? nullptr : &Diags)	DumpInput == DumpInputNever ? nullptr : &Diags)
Context not available.