This is an archive of the discontinued LLVM Phabricator instance.

[X86] Rename O3-pipeline.ll to opt-pipeline.ll and add O1/O2 command lines.
ClosedPublic

Authored by craig.topper on Jun 23 2020, 5:27 PM.

Details

Summary

Eric Cristopher asked me about possibly disabling some passes at
-O1/Og. Figured a good first step was to test all the pipelines.
They all appear to be the same for now. Hoping we can use FileCheck
prefixes for differences to avoid repeating the contents 3 times.

Diff Detail

Event Timeline

craig.topper created this revision.Jun 23 2020, 5:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 23 2020, 5:27 PM
This revision is now accepted and ready to land.Jun 24 2020, 12:29 AM

I do not understand why we can't just have llvm/test/CodeGen/X86/O{0,1,2,3}-pipeline.ll, like there already is for plain opt?

I do not understand why we can't just have llvm/test/CodeGen/X86/O{0,1,2,3}-pipeline.ll, like there already is for plain opt?

I was just trying to make it so updating the pipeline didn’t require editing 3 files. We also have changes to this test in our downstream code base so I was trying to make it just work when we synced this change.