This is an archive of the discontinued LLVM Phabricator instance.

Differential D82333

[mlir][mlir-rocm-runner] Remove compile-time warning. NFC.
ClosedPublic

Authored by whchung on Jun 22 2020, 3:07 PM.

Details

Reviewers
jerryyin
Commits
rGb7c4912996d6: [mlir][mlir-rocm-runner] Remove compile-time warning. NFC.
Summary

Remove compile-time warning. NFC.

Diff Detail

Event Timeline

whchung created this revision.Jun 22 2020, 3:07 PM
Herald added subscribers: msifontes, jurahul, Kayjukh and 14 others. · View Herald TranscriptJun 22 2020, 3:07 PM
whchung edited the summary of this revision. (Show Details)Jun 22 2020, 3:08 PM
whchung added a reviewer: jerryyin.
jerryyin accepted this revision.Jun 22 2020, 3:41 PM

LGTM

This revision is now accepted and ready to land.Jun 22 2020, 3:41 PM
Harbormaster failed remote builds in B61305: Diff 272552!Jun 22 2020, 4:07 PM
Closed by commit rGb7c4912996d6: [mlir][mlir-rocm-runner] Remove compile-time warning. NFC. (authored by whchung). · Explain WhyJun 22 2020, 8:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
tools/
mlir-rocm-runner/
2 lines

Diff 272552

mlir/tools/mlir-rocm-runner/mlir-rocm-runner.cpp

Show First 20 Lines • Show All 53 Lines • ▼ Show 20 Lines
#include "llvm/MC/MCParser/AsmLexer.h" #include "llvm/MC/MCParser/AsmLexer.h"
#include "llvm/MC/MCParser/MCTargetAsmParser.h" #include "llvm/MC/MCParser/MCTargetAsmParser.h"
#include "llvm/MC/MCRegisterInfo.h" #include "llvm/MC/MCRegisterInfo.h"
#include "llvm/MC/MCStreamer.h" #include "llvm/MC/MCStreamer.h"
#include "llvm/MC/MCSubtargetInfo.h" #include "llvm/MC/MCSubtargetInfo.h"
#include "llvm/MC/MCTargetOptionsCommandFlags.h" #include "llvm/MC/MCTargetOptionsCommandFlags.h"
// lld headers. // lld headers.
#include "lld/Common/Driver.h" #include "lld/Common/Driver.h"
Lint: Pre-merge checks
Inline Actions

clang-tidy: error: 'lld/Common/Driver.h' file not found [clang-diagnostic-error]
not useful

Lint: Pre-merge checks: clang-tidy: error: 'lld/Common/Driver.h' file not found [clang-diagnostic-error] [[https…
// HIP headers. // HIP headers.
#include "hip/hip_version.h" #include "hip/hip_version.h"
using namespace mlir; using namespace mlir;
using namespace llvm; using namespace llvm;
using Blob = SmallVector<char, 0>; using Blob = SmallVector<char, 0>;
▲ Show 20 Lines • Show All 151 Lines • ▼ Show 20 Lines
static void configTargetChip() { static void configTargetChip() {
// Set targetChip to default value first. // Set targetChip to default value first.
targetChip = kDefaultTargetChip; targetChip = kDefaultTargetChip;
// Locate rocm_agent_enumerator. // Locate rocm_agent_enumerator.
llvm::ErrorOr<std::string> rocmAgentEnumerator = llvm::sys::findProgramByName( llvm::ErrorOr<std::string> rocmAgentEnumerator = llvm::sys::findProgramByName(
kRocmAgentEnumerator, {__ROCM_PATH__ "/bin"}); kRocmAgentEnumerator, {__ROCM_PATH__ "/bin"});
std::error_code ec; std::error_code ec;
if (ec = rocmAgentEnumerator.getError()) { if ((ec = rocmAgentEnumerator.getError())) {
WithColor::warning(errs(), kRunnerProgram) WithColor::warning(errs(), kRunnerProgram)
<< kRocmAgentEnumerator << " couldn't be located under " << kRocmAgentEnumerator << " couldn't be located under "
<< __ROCM_PATH__ << ", set target as " << kDefaultTargetChip << "\n"; << __ROCM_PATH__ << ", set target as " << kDefaultTargetChip << "\n";
return; return;
} }
// Prepare temp file to hold the outputs. // Prepare temp file to hold the outputs.
int tempFd = -1; int tempFd = -1;
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines