Fix a corner case in vector.shape_cast when the trailing dimensions are of size 1.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Dialect/Vector/VectorOps.cpp | ||
---|---|---|
1633 | I find the * followed by / hard to read. Can we |
mlir/lib/Dialect/Vector/VectorOps.cpp | ||
---|---|---|
1636 | Hmm looks like this could fail if both a and b have trailing ones since only j makes progress and the late i == rankA check will later fail? How about explicitly checking for llvm::all_of(a... ) and llvm::all_of(b... ) are 1 ? |
I find the * followed by / hard to read. Can we
(1) add comments on what we are doing here
(2) find better logic that tests before doing the * and canceling /?