This is an archive of the discontinued LLVM Phabricator instance.

Differential D82231

[NFC] Remove unused pass name parser classes
ClosedPublic

Authored by aeubanks on Jun 19 2020, 12:48 PM.

Details

Reviewers
echristo
Commits
rG2565581e3704: [NFC] Remove unused pass name parser classes
Summary

Looks like these were for the most part touched over a decade ago.

Diff Detail

Event Timeline

aeubanks created this revision.Jun 19 2020, 12:48 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 19 2020, 12:48 PM
Herald added subscribers: llvm-commits, cfe-commits, mgorny. · View Herald Transcript
aeubanks added a reviewer: echristo.Jun 19 2020, 12:48 PM
aeubanks updated this revision to Diff 272166.Jun 19 2020, 12:50 PM

Unintended change

echristo accepted this revision.Jun 19 2020, 1:16 PM
This revision is now accepted and ready to land.Jun 19 2020, 1:16 PM
Closed by commit rG2565581e3704: [NFC] Remove unused pass name parser classes (authored by aeubanks). · Explain WhyJun 19 2020, 2:09 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B61090: Diff 272164!Jun 19 2020, 2:42 PM
Harbormaster completed remote builds in B61091: Diff 272166.Jun 19 2020, 3:14 PM

Revision Contents

PathSize
clang/
2 lines
llvm/
include/
llvm/
IR/
41 lines

Diff 272164

clang/CMakeLists.txt

Show First 20 Lines • Show All 250 Lines • ▼ Show 20 Lines
set(DEFAULT_SYSROOT "" CACHE STRING set(DEFAULT_SYSROOT "" CACHE STRING
"Default <path> to all compiler invocations for --sysroot=<path>." ) "Default <path> to all compiler invocations for --sysroot=<path>." )
set(ENABLE_LINKER_BUILD_ID OFF CACHE BOOL "pass --build-id to ld") set(ENABLE_LINKER_BUILD_ID OFF CACHE BOOL "pass --build-id to ld")
set(ENABLE_X86_RELAX_RELOCATIONS OFF CACHE BOOL set(ENABLE_X86_RELAX_RELOCATIONS OFF CACHE BOOL
"enable x86 relax relocations by default") "enable x86 relax relocations by default")
set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER TRUE CACHE BOOL
"Enable the experimental new pass manager by default.") "Enable the experimental new pass manager by default.")
set(CLANG_SPAWN_CC1 OFF CACHE BOOL set(CLANG_SPAWN_CC1 OFF CACHE BOOL
"Whether clang should use a new process for the CC1 invocation") "Whether clang should use a new process for the CC1 invocation")
# TODO: verify the values against LangStandards.def? # TODO: verify the values against LangStandards.def?
set(CLANG_DEFAULT_STD_C "" CACHE STRING set(CLANG_DEFAULT_STD_C "" CACHE STRING
"Default standard to use for C/ObjC code (IDENT from LangStandards.def, empty for platform default)") "Default standard to use for C/ObjC code (IDENT from LangStandards.def, empty for platform default)")
▲ Show 20 Lines • Show All 631 Lines • Show Last 20 Lines

llvm/include/llvm/IR/LegacyPassNameParser.h

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines
private: private:
// ValCompare - Provide a sorting comparator for Values elements... // ValCompare - Provide a sorting comparator for Values elements...
static int ValCompare(const PassNameParser::OptionInfo *VT1, static int ValCompare(const PassNameParser::OptionInfo *VT1,
const PassNameParser::OptionInfo *VT2) { const PassNameParser::OptionInfo *VT2) {
return VT1->Name.compare(VT2->Name); return VT1->Name.compare(VT2->Name);
} }
}; };
///===----------------------------------------------------------------------===//
/// FilteredPassNameParser class - Make use of the pass registration
/// mechanism to automatically add a command line argument to opt for
/// each pass that satisfies a filter criteria. Filter should return
/// true for passes to be registered as command-line options.
///
template<typename Filter>
class FilteredPassNameParser : public PassNameParser {
private:
Filter filter;
public:
bool ignorablePassImpl(const PassInfo *P) const override {
return !filter(*P);
}
};
///===----------------------------------------------------------------------===//
/// PassArgFilter - A filter for use with PassNameFilterParser that only
/// accepts a Pass whose Arg matches certain strings.
///
/// Use like this:
///
/// extern const char AllowedPassArgs[] = "-anders_aa -dse";
///
/// static cl::list<
/// const PassInfo*,
/// bool,
/// FilteredPassNameParser<PassArgFilter<AllowedPassArgs> > >
/// PassList(cl::desc("Passes available:"));
///
/// Only the -anders_aa and -dse options will be available to the user.
///
template<const char *Args>
class PassArgFilter {
public:
bool operator()(const PassInfo &P) const {
return StringRef(Args).contains(P.getPassArgument());
}
};
} // End llvm namespace } // End llvm namespace
#endif #endif