This is an archive of the discontinued LLVM Phabricator instance.

[ARM][MVE] Don't revert get.active.lane.mask in tail-predication pass
ClosedPublic

Authored by SjoerdMeijer on Jun 18 2020, 8:55 AM.

Details

Summary

Don't revert intrinsic get.active.lane.mask here, this is moved to isel legalization in D82292.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Jun 18 2020, 8:55 AM
efriedma added inline comments.Jun 18 2020, 2:31 PM
llvm/lib/Target/ARM/MVETailPredication.cpp
164–165

I think I'd prefer if you just taught isel legalization to lower llvm.get.active.lane.mask calls, rather than depend on the MVETailPredication pass running before isel.

SjoerdMeijer retitled this revision from [ARM][MVE] Tail-Prediction: revert multiple get.active.lane.mask intrinsics to [ARM][MVE] Tail-Prediction: don't revert multiple get.active.lane.mask.
SjoerdMeijer edited the summary of this revision. (Show Details)

Ok, thanks.

This change now:

  • strips out everything related to reverting the intrinsic,
  • some light refactoring here and there.
This revision is now accepted and ready to land.Jun 19 2020, 1:13 PM
SjoerdMeijer retitled this revision from [ARM][MVE] Tail-Prediction: don't revert multiple get.active.lane.mask to [ARM][MVE] Don't revert get.active.lane.mask in tail-predication pass.Jun 22 2020, 6:09 AM
SjoerdMeijer edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.