Page MenuHomePhabricator

[DWARFYAML][debug_addr] Use unsigned integer in Length, Version, etc. NFC.
AbandonedPublic

Authored by Higuoxing on Jun 17 2020, 12:02 AM.

Details

Summary

This patch doesn't make a big difference. But it will be easier for us to read values from these fields once obj2yaml supports dumping this section.

Diff Detail

Event Timeline

Higuoxing created this revision.Jun 17 2020, 12:02 AM
jhenderson added inline comments.Jun 17 2020, 1:00 AM
llvm/include/llvm/ObjectYAML/DWARFYAML.h
170

I think length fields are generally better represented as hex, not decimal, so I wouldn't change those. I don't care much either way for the other fields.

Harbormaster completed remote builds in B60590: Diff 271285.
Higuoxing abandoned this revision.Thu, Jul 23, 1:14 AM

Currently, obj2yaml doesn't support the .debug_addr section. Abandon.