Page MenuHomePhabricator

[SVE] Generalize size checks in Verifier to use getElementCount
ClosedPublic

Authored by ctetreau on Jun 15 2020, 4:29 PM.

Details

Summary

Attempts to call getNumElements on scalable vectors identified by test
LLVM.Other::scalable-vectors-core-ir.ll. Since these checks are all
attempting to find if two vectors are the same size, calling
getElementCount will only increase safety.

Diff Detail

Event Timeline

ctetreau created this revision.Jun 15 2020, 4:29 PM
Herald added a project: Restricted Project. · View Herald Transcript
efriedma accepted this revision.Jun 16 2020, 2:18 PM

LGTM

I guess it isn't practical to write a testcase for the potential verifier failures because we have equivalent assertions in the constructors for these instructions.

This revision is now accepted and ready to land.Jun 16 2020, 2:18 PM
This revision was automatically updated to reflect the committed changes.