This is an archive of the discontinued LLVM Phabricator instance.

Differential D81878

[mlir] [integration_test] Make integration tests default OFF
ClosedPublic

Authored by aartbik on Jun 15 2020, 1:57 PM.

Details

Reviewers
mehdi_amini
Commits
rG8d73ab8ddc52: [mlir] [integration_test] Make integration tests default OFF
Summary

Previous submit of new tests accidentally made this ON.
The tests should be opt-in.

To build with MLIR integration tests enabled, pass the following

cmake .... \
-DMLIR_INCLUDE_INTEGRATION_TESTS=ON \
....

Diff Detail

Event Timeline

aartbik created this revision.Jun 15 2020, 1:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2020, 1:57 PM
Herald added subscribers: msifontes, jurahul, Kayjukh and 15 others. · View Herald Transcript
aartbik edited the summary of this revision. (Show Details)Jun 15 2020, 2:05 PM
aartbik added a reviewer: mehdi_amini.
aartbik edited the summary of this revision. (Show Details)Jun 15 2020, 2:08 PM
Harbormaster failed remote builds in B60362: Diff 270855!Jun 15 2020, 2:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 15 2020, 2:55 PM
Closed by commit rG8d73ab8ddc52: [mlir] [integration_test] Make integration tests default OFF (authored by aartbik). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
3 lines

Diff 270875

mlir/CMakeLists.txt

Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
set(MLIR_ROCM_RUNNER_ENABLED 0 CACHE BOOL "Enable building the mlir ROCm runner") set(MLIR_ROCM_RUNNER_ENABLED 0 CACHE BOOL "Enable building the mlir ROCm runner")
set(MLIR_VULKAN_RUNNER_ENABLED 0 CACHE BOOL "Enable building the mlir Vulkan runner") set(MLIR_VULKAN_RUNNER_ENABLED 0 CACHE BOOL "Enable building the mlir Vulkan runner")
option(MLIR_INCLUDE_TESTS option(MLIR_INCLUDE_TESTS
"Generate build targets for the MLIR unit tests." "Generate build targets for the MLIR unit tests."
${LLVM_INCLUDE_TESTS}) ${LLVM_INCLUDE_TESTS})
option(MLIR_INCLUDE_INTEGRATION_TESTS option(MLIR_INCLUDE_INTEGRATION_TESTS
"Generate build targets for the MLIR integration tests." "Generate build targets for the MLIR integration tests.")
${LLVM_INCLUDE_TESTS})
include_directories( "include") include_directories( "include")
include_directories( ${MLIR_INCLUDE_DIR}) include_directories( ${MLIR_INCLUDE_DIR})
# Adding tools/mlir-tblgen here as calling add_tablegen sets some variables like # Adding tools/mlir-tblgen here as calling add_tablegen sets some variables like
# MLIR_TABLEGEN_EXE in PARENT_SCOPE which gets lost if that folder is included # MLIR_TABLEGEN_EXE in PARENT_SCOPE which gets lost if that folder is included
# from another directory like tools # from another directory like tools
add_subdirectory(tools/mlir-tblgen) add_subdirectory(tools/mlir-tblgen)
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines